You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2008/10/15 15:17:44 UTC
[jira] Created: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
JobTracker.killJob() doesn't check for the JobID being valid
------------------------------------------------------------
Key: HADOOP-4420
URL: https://issues.apache.org/jira/browse/HADOOP-4420
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Affects Versions: 0.19.0, 0.20.0
Reporter: Steve Loughran
Priority: Minor
As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643805#action_12643805 ]
Aaron Kimball commented on HADOOP-4420:
---------------------------------------
Should also add: no unit tests, because it's just straightforward null checks.
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4420.patch
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-4420:
----------------------------------
Attachment: hadoop-4420.patch
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4420.patch
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643806#action_12643806 ]
Vinod K V commented on HADOOP-4420:
-----------------------------------
For Hadoop-0.20, we should think about ways of informing clients about the failures, instead of just returning silently, as Hemanth pointed out [here|https://issues.apache.org/jira/browse/HADOOP-4419?focusedCommentId=12639889#action_12639889]. This needs API changes and so the approach in the current patch is fine for 0.19.
Some comments about this patch.
- You don't have a null check for JobID in setJobPriority.
- The update you made for Changes.txt is not getting applied cleanly. I think you can leave that to be done by the committer of this patch.
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4420.patch
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-4420:
----------------------------------
Status: Open (was: Patch Available)
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651219#action_12651219 ]
Hadoop QA commented on HADOOP-4420:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393334/hadoop-4420.patch.2
against trunk revision 720930.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3656/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3656/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3656/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3656/console
This message is automatically generated.
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0, 0.18.1, 0.18.2
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-4420:
----------------------------------
Fix Version/s: 0.19.1
Affects Version/s: (was: 0.20.0)
(was: 0.19.0)
0.18.0
0.18.1
0.18.2
Status: Patch Available (was: Open)
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.2, 0.18.1, 0.18.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-4420:
----------------------------------
Comment: was deleted
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0, 0.18.1, 0.18.2
> Reporter: Steve Loughran
> Assignee: Aaron Kimball
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas reassigned HADOOP-4420:
-------------------------------------
Assignee: Aaron Kimball
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0, 0.18.1, 0.18.2
> Reporter: Steve Loughran
> Assignee: Aaron Kimball
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-4420:
------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Aaron!
See HADOOP-4725 for a follow-on feature to notify clients when they pass bad job IDs.
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0, 0.18.1, 0.18.2
> Reporter: Steve Loughran
> Assignee: Aaron Kimball
> Priority: Minor
> Fix For: 0.19.1, 0.20.0
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643961#action_12643961 ]
Hadoop QA commented on HADOOP-4420:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393039/hadoop-4420.patch
against trunk revision 709040.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3511/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3511/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3511/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3511/console
This message is automatically generated.
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4420.patch
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-4420:
----------------------------------
Status: Patch Available (was: Open)
This also fixes HADOOP-4419 at the same time
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4420.patch
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-4420:
----------------------------------
Attachment: hadoop-4420.patch.2
Added null check and log warning on jobid to getJobStatus(); also added null check in o.a.h.m.CompletedJobStore.readJobStatus() which it calls.
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651233#action_12651233 ]
Aaron Kimball commented on HADOOP-4420:
---------------------------------------
core test failure is due to something in DFS testFileAppend -- Can't see how it's related to this.
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0, 0.18.1, 0.18.2
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652688#action_12652688 ]
Aaron Kimball commented on HADOOP-4420:
---------------------------------------
Hello,
I'm at a workshop in Tel Aviv until 12/8; my email access is sporadic,
and the timezone is offset by 10 hours from PST. I'll get back to you
as soon as I can.
Thank you,
- Aaron Kimball
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0, 0.18.1, 0.18.2
> Reporter: Steve Loughran
> Assignee: Aaron Kimball
> Priority: Minor
> Fix For: 0.19.1
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check
for the JobID being valid
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654082#action_12654082 ]
Hudson commented on HADOOP-4420:
--------------------------------
Integrated in Hadoop-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/680/])
> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
> Key: HADOOP-4420
> URL: https://issues.apache.org/jira/browse/HADOOP-4420
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0, 0.18.1, 0.18.2
> Reporter: Steve Loughran
> Assignee: Aaron Kimball
> Priority: Minor
> Fix For: 0.19.1, 0.20.0
>
> Attachments: hadoop-4420.patch, hadoop-4420.patch.2
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches to a valid job.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.