You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Andrew Lunny (Created) (JIRA)" <ji...@apache.org> on 2012/01/02 03:41:30 UTC
[jira] [Created] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
[PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
------------------------------------------------------------------------------
Key: CB-147
URL: https://issues.apache.org/jira/browse/CB-147
Project: Apache Callback
Issue Type: New Feature
Components: Android
Affects Versions: 1.3.0
Reporter: Andrew Lunny
Fix For: 1.3.0
Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch
Two patch files:
* 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
* 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
Posted by "Andrew Lunny (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Lunny updated CB-147:
----------------------------
Attachment: 0002-using-preference-fullscreen-for-fullscreen-view.patch
0001-reading-preferences-from-phonegap.xml.patch
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Fix For: 1.3.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CB-147) [PATCH] add support for
to res/xml/phonegap.xml
Posted by "Andrew Lunny (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178645#comment-13178645 ]
Andrew Lunny edited comment on CB-147 at 1/3/12 6:41 AM:
---------------------------------------------------------
extra patch on top - some error-checking/encapsulation to avoid NullPointerExceptions
was (Author: alunny):
extra patch on top
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Fix For: 1.3.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch, 0003-making-preference-reading-code-more-robust.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
Posted by "Andrew Lunny (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182997#comment-13182997 ]
Andrew Lunny commented on CB-147:
---------------------------------
created pull request on github - https://github.com/cordova/cordova-android/pull/3
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Fix For: 1.4.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch, 0003-making-preference-reading-code-more-robust.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
Posted by "Joe Bowser (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser closed CB-147.
-------------------------
Assignee: Joe Bowser
Good job Andrew!
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Assignee: Joe Bowser
> Fix For: 1.4.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch, 0003-making-preference-reading-code-more-robust.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
Posted by "Simon MacDonald (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon MacDonald updated CB-147:
-------------------------------
Fix Version/s: (was: 1.3.0)
1.4.0
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Fix For: 1.4.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch, 0003-making-preference-reading-code-more-robust.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
Posted by "Andrew Lunny (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Lunny updated CB-147:
----------------------------
Attachment: 0003-making-preference-reading-code-more-robust.patch
extra patch on top
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Fix For: 1.3.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch, 0003-making-preference-reading-code-more-robust.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-147) [PATCH] add support for to res/xml/phonegap.xml
Posted by "Joe Bowser (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser resolved CB-147.
---------------------------
Resolution: Fixed
This has already been patched, and this will be the way we now handle all preferences in PhoneGap-Android moving forward.
> [PATCH] add support for <preference name="fullscreen"> to res/xml/phonegap.xml
> ------------------------------------------------------------------------------
>
> Key: CB-147
> URL: https://issues.apache.org/jira/browse/CB-147
> Project: Apache Callback
> Issue Type: New Feature
> Components: Android
> Affects Versions: 1.3.0
> Reporter: Andrew Lunny
> Fix For: 1.4.0
>
> Attachments: 0001-reading-preferences-from-phonegap.xml.patch, 0002-using-preference-fullscreen-for-fullscreen-view.patch, 0003-making-preference-reading-code-more-robust.patch
>
>
> Two patch files:
> * 0001 modifies DroidGap.loadConfiguration to look for <preference> tags. Preference tag syntax matches that specified by the W3C config.xml spec (http://www.w3.org/TR/widgets/#the-preference-element-and-its-attributes). Two extra classes - PreferenceNode and PreferenceSet - are created for this purpose. Tests are present for these two classes (depending on an earlier patch - see issue CB-146).
> * 0002 uses the PreferenceNode/PreferenceSet added by 0001 to look for a "fullscreen" preference in res/xml/phonegap.xml. If present and set to "true", the WindowManager.LayoutParams.FLAG_FULLSCREEN flag is set on the main DroidGap window
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira