[jira] [Commented] (HBASE-13460) Revise the MetaLookupPool executor-related defaults (introduced in HBASE-13036)

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493534#comment-14493534 ] 

Hadoop QA commented on HBASE-13460:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12725136/13460-master-1.txt
  against master branch at commit e9da064ccd8dd3c64d99e0863e36cdc1236779f1.
  ATTACHMENT ID: 12725136

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestClientNoCluster

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13689//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13689//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13689//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13689//console

This message is automatically generated.

> Revise the MetaLookupPool executor-related defaults (introduced in HBASE-13036)
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-13460
>                 URL: https://issues.apache.org/jira/browse/HBASE-13460
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 1.1.0
>
>         Attachments: 13460-master-1.txt
>
>
> The value of the max threads, max tasks, etc. can be improved to not unnecessarily reject tasks. In one of our internal tests, we saw tasks getting rejected (with the defaults that is currently there in the unpatched code):
> {noformat}
> 2015-04-09 12:36:34,111|beaver.machine|INFO|15134|140028818736896|MainThread|Caused by: java.lang.RuntimeException: java.util.concurrent.RejectedExecutionException: Task 
> org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture@6658c97b rejected from 
> java.util.concurrent.ThreadPoolExecutor@5a06eeee[Running, pool size = 3, active threads = 3, queued tasks = 300, completed tasks = 0]
> 2015-04-09 12:36:34,111|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:208)
> 2015-04-09 12:36:34,112|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.ClientSmallReversedScanner.next(ClientSmallReversedScanner.java:145)
> 2015-04-09 12:36:34,112|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegionInMeta(ConnectionManager.java:1246)
> 2015-04-09 12:36:34,112|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegion(ConnectionManager.java:1152)
> 2015-04-09 12:36:34,113|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.AsyncProcess.submit(AsyncProcess.java:370)
> 2015-04-09 12:36:34,113|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.AsyncProcess.submit(AsyncProcess.java:321)
> 2015-04-09 12:36:34,113|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.BufferedMutatorImpl.backgroundFlushCommits(BufferedMutatorImpl.java:206)
> 2015-04-09 12:36:34,113|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush(BufferedMutatorImpl.java:183)
> 2015-04-09 12:36:34,114|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.HTable.flushCommits(HTable.java:1414)
> 2015-04-09 12:36:34,114|beaver.machine|INFO|15134|140028818736896|MainThread|at org.apache.hadoop.hbase.client.HTable.put(HTable.java:1010)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)