You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/02/16 16:50:43 UTC

[GitHub] flink pull request: [FLINK-3400] Move RocksDB Copy Utils to flink-...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1644

    [FLINK-3400] Move RocksDB Copy Utils to flink-streaming-java

    They are not specific to RocksDB, just utilities for copying local
    folders to/from HDFS. Moving them to flink-streaming-java means that
    they are always in the classpath of the TaskManager, not only in the
    user-code jar when using RocksDB. If they are only in the user-code jar
    the external process runner cannot find the class files, leading to
    ClassNotFoundExceptions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink rocksdb-fix-copy-utils

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1644
    
----
commit 6dfdf5d643d9df2598b25f61134e24ab37ecb7df
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-15T12:57:15Z

    [FLINK-3400] Move RocksDB Copy Utils to flink-streaming-java
    
    They are not specific to RocksDB, just utilities for copying local
    folders to/from HDFS. Moving them to flink-streaming-java means that
    they are always in the classpath of the TaskManager, not only in the
    user-code jar when using RocksDB. If they are only in the user-code jar
    the external process runner cannot find the class files, leading to
    ClassNotFoundExceptions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3400] Move RocksDB Copy Utils to flink-...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1644#issuecomment-184891874
  
    Looks good, +1 to merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3400] Move RocksDB Copy Utils to flink-...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha closed the pull request at:

    https://github.com/apache/flink/pull/1644


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---