You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2025/09/01 12:46:32 UTC

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

mimaison commented on code in PR #15516:
URL: https://github.com/apache/kafka/pull/15516#discussion_r2313866487


##########
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##########
@@ -293,14 +294,15 @@ private static MemoryRecordsBuilder buildRetainedRecordsInto(RecordBatch origina
                                                                  ByteBufferOutputStream bufferOutputStream,
                                                                  final long deleteHorizonMs) {
         byte magic = originalBatch.magic();
+        Compression compression = Compression.of(originalBatch.compressionType()).build();

Review Comment:
   1. Right, here we could use the level if specified. I expect most topics to use `compression.type=producer` but in case a specific compression type and level is set, that would make sense to use them.
   
   2. It's not something I thought about before. Do you think there are scenarios where the gains of picking a different level for older data would be significant enough to motivate such a feature?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org