[GitHub] trafficserver pull request: TS-3155

[shinrich <gi...@git.apache.org>]

GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/139

    TS-3155

    Adding value_get_index to test for presence of value in MIME header field.
    Using it in the keep alive checks.  There are other places in the code
    where this change can be used to avoid full value copy and parsing.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver ts-3155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #139
    
----
commit e3dd78f250e40316895415614fe7a73b64ad061b
Author: shinrich <sh...@network-geographics.com>
Date:   2014-11-07T17:31:03Z

    TS-3155
    Adding value_get_index to test for presence of value in MIME header field.
    Using it in the keep alive checks.  There are other places in the code
    where this change can be used to avoid full value copy and parsing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-3155

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-3155

[jpeach <gi...@git.apache.org>]

Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/139#issuecomment-62421425
  
    This looks pretty good. Please use `strncasecmp() == 0` instead of `!strncasecmp()`. The former is easier to read and consistent with the rest of the code.
    
    I'm not sure whether `strncasecmp` is the right comparison operation here. The code in `MIME.cc` uses a mixture of `strcasecmp` and the `ParseRules` API. I suspect that `ptr_len_casecmp` would be the right API to use.
    
    I'm not sure how involved it would be, but please consider adding a regression test for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---