You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2009/02/05 23:25:07 UTC
svn commit: r741318 - in /hadoop/hbase/branches/0.19: CHANGES.txt
src/java/org/apache/hadoop/hbase/HColumnDescriptor.java
Author: apurtell
Date: Thu Feb 5 22:25:07 2009
New Revision: 741318
URL: http://svn.apache.org/viewvc?rev=741318&view=rev
Log:
HBASE-1184 HColumnDescriptor is too resrictive with family names
Modified:
hadoop/hbase/branches/0.19/CHANGES.txt
hadoop/hbase/branches/0.19/src/java/org/apache/hadoop/hbase/HColumnDescriptor.java
Modified: hadoop/hbase/branches/0.19/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.19/CHANGES.txt?rev=741318&r1=741317&r2=741318&view=diff
==============================================================================
--- hadoop/hbase/branches/0.19/CHANGES.txt (original)
+++ hadoop/hbase/branches/0.19/CHANGES.txt Thu Feb 5 22:25:07 2009
@@ -12,6 +12,8 @@
HBASE-845 HCM.isTableEnabled doesn't really tell if it is, or not
HBASE-903 [shell] Can't set table descriptor attributes when I alter a table
HBASE-1178 Add shutdown command to shell
+ HBASE-1184 HColumnDescriptor is too restrictive with family names
+ (Toby White via Andrew Purtell)
Release 0.19.0
INCOMPATIBLE CHANGES
Modified: hadoop/hbase/branches/0.19/src/java/org/apache/hadoop/hbase/HColumnDescriptor.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.19/src/java/org/apache/hadoop/hbase/HColumnDescriptor.java?rev=741318&r1=741317&r2=741318&view=diff
==============================================================================
--- hadoop/hbase/branches/0.19/src/java/org/apache/hadoop/hbase/HColumnDescriptor.java (original)
+++ hadoop/hbase/branches/0.19/src/java/org/apache/hadoop/hbase/HColumnDescriptor.java Thu Feb 5 22:25:07 2009
@@ -237,12 +237,11 @@
Bytes.toString(b));
}
for (int i = 0; i < (b.length - 1); i++) {
- if (Character.isLetterOrDigit(b[i]) || b[i] == '_' || b[i] == '.') {
- continue;
+ if (Character.isISOControl(b[i])) {
+ throw new IllegalArgumentException("Illegal character <" + b[i] +
+ ">. Family names cannot contain control characters: " +
+ Bytes.toString(b));
}
- throw new IllegalArgumentException("Illegal character <" + b[i] +
- ">. Family names can only contain 'word characters' and must end" +
- "with a colon: " + Bytes.toString(b));
}
return b;
}