[GitHub] [hbase] virajjasani commented on a change in pull request #2890: HBASE-25509 ChoreService.cancelChore will not call ScheduledChore.cle…

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #2890:
URL: https://github.com/apache/hbase/pull/2890#discussion_r558819095



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -2649,15 +2649,16 @@ private void scheduleAbortTimer() {
   protected void stopServiceThreads() {
     // clean up the scheduled chores
     if (this.choreService != null) {
-      choreService.cancelChore(nonceManagerChore);
-      choreService.cancelChore(compactionChecker);
-      choreService.cancelChore(periodicFlusher);
-      choreService.cancelChore(healthCheckChore);
-      choreService.cancelChore(executorStatusChore);
-      choreService.cancelChore(storefileRefresher);
-      choreService.cancelChore(fsUtilizationChore);
-      choreService.cancelChore(slowLogTableOpsChore);
-      // clean up the remaining scheduled chores (in case we missed out any)
+      nonceManagerChore.shutdown();
+      compactionChecker.shutdown();
+      periodicFlusher.shutdown();
+      healthCheckChore.shutdown();
+      executorStatusChore.shutdown();
+      storefileRefresher.shutdown();
+      fsUtilizationChore.shutdown();
+      slowLogTableOpsChore.shutdown();

Review comment:
       All of these are mandatory chores right? Any chances, any chore can be null?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org