You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2019/05/29 17:17:00 UTC
[jira] [Commented] (CALCITE-3095) Add several system properties to
control enabling/disabling of rules and traits
[ https://issues.apache.org/jira/browse/CALCITE-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851077#comment-16851077 ]
Julian Hyde commented on CALCITE-3095:
--------------------------------------
Thanks for splitting out as a separate commit:
* Change 'This is a utility class ...' to 'A utility class'. Direct is good.
* Remove blank line in RelOptRules constructor.
* In description of the new properties, change 'Whether streaming is enabled' to 'Whether streaming is enabled in the default planner configuration', etc. People should know that they can enable streaming by building their own rule sets.
* No need to deprecate ENABLE_COLLATION_TRAIT. It is private. Just remove it.
All of these comments are optional. +1 to commit whenever you're ready.
> Add several system properties to control enabling/disabling of rules and traits
> -------------------------------------------------------------------------------
>
> Key: CALCITE-3095
> URL: https://issues.apache.org/jira/browse/CALCITE-3095
> Project: Calcite
> Issue Type: Improvement
> Reporter: Hongze Zhang
> Priority: Major
> Labels: pull-request-available
>
> This is to make following constant flags configurable from Calcite system properties:
> * CalcitePrepareImpl.ENABLE_COLLATION_TRAIT
> * CalcitePrepareImpl.ENABLE_ENUMERABLE
> * CalcitePrepareImpl.ENABLE_STREAM
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)