You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/02/09 10:53:18 UTC
[jira] [Commented] (CB-10102) statusbar removeObserver is wrong
[ https://issues.apache.org/jira/browse/CB-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138665#comment-15138665 ]
ASF subversion and git services commented on CB-10102:
------------------------------------------------------
Commit a464526477fecf15c091856d1a152e8eb38be033 in cordova-plugin-statusbar's branch refs/heads/2.1.x from [~jcesarmobile]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=a464526 ]
Fix for CB-10102
The removeObserver code was wrong and it might crash on plugin
deallocation
github: close #45
> statusbar removeObserver is wrong
> ---------------------------------
>
> Key: CB-10102
> URL: https://issues.apache.org/jira/browse/CB-10102
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Statusbar
> Environment: iOS
> Reporter: jcesarmobile
> Assignee: jcesarmobile
> Priority: Minor
>
> The current code is wrong
> {code}[[NSNotificationCenter defaultCenter] removeObserver:self forKeyPath:UIApplicationDidChangeStatusBarFrameNotification];
> {code}
> It should be
> {code}
> [[NSNotificationCenter defaultCenter]removeObserver:self name:UIApplicationDidChangeStatusBarOrientationNotification object:nil];
> {code}
> It might crash on plugin dealocation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org