[GitHub] [geode] agingade commented on a change in pull request #7199: GEODE-9770: Retry creating region when cache is closed

[GitBox <gi...@apache.org>]

agingade commented on a change in pull request #7199:
URL: https://github.com/apache/geode/pull/7199#discussion_r768883138



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/persistence/PersistentRecoveryOrderDUnitTest.java
##########
@@ -1327,8 +1327,19 @@ public void testRecoverAfterConflict() {
 
     vm0.invoke(() -> {
       // This should work now
-      createReplicateRegion(regionName, getDiskDirs(getVMId()));
-      updateEntry("A", "C");
+      try {
+        createReplicateRegion(regionName, getDiskDirs(getVMId()));
+        updateEntry("A", "C");
+      } catch (CacheClosedException cacheClosedException) {

Review comment:
       If cache gets closed whenever "ConflictingPersistentDataExcpetion" is thrown; will it be a good option to wait for cache to be closed before recreating the replicated-region?
   That way it becomes easier to understand the flow/expectation at different blocks of the test.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org