[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #351: [FLINK-28812] Support to read compacted snapshot only

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #351:
URL: https://github.com/apache/flink-table-store/pull/351#discussion_r1026052672


##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java:
##########
@@ -100,6 +100,9 @@ public SplitEnumerator<FileStoreSourceSplit, PendingSplitsCheckpoint> restoreEnu
                     // Only full compaction results will appear on the max level.
                     plan = scan.withLevel(table.options().numLevels() - 1).plan();
                 } else {
+                    if (!isContinuous) {

Review Comment:
   For full streaming reading, I think we should enable read compacted too.
   In essence, we want to introduce this option to make the read merging more efficient. Full incremental streaming read also requires this capability in the full reading part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org