You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "1fanwang (via GitHub)" <gi...@apache.org> on 2026/09/09 09:20:23 UTC
[PR] UI: Complete Simplified Chinese translations [airflow]
1fanwang opened a new pull request, #72789:
URL: https://github.com/apache/airflow/pull/72789
## Why
The Simplified Chinese UI falls back to English for nine strings on `v3-3-test`, leaving the locale below complete coverage ahead of Airflow 3.3.2. The locale also retains two fullscreen keys that the current UI no longer reads.
## What
Translate the missing date and time controls, password visibility labels, asset-run relationship, dynamic deadline rule, latest bundle-version tooltip, and active-run count. Remove the obsolete fullscreen keys. zh-CN now covers all 988 required strings.
## Tests
| Scenario | Result |
| --- | --- |
| Translation completeness | 979/988 before; 988/988 after |
| UI unit tests | 98 files; 793 tests passed |
| Production UI build | Passed |
<details><summary>Raw logs</summary>
```text
# upstream/v3-3-test
$ breeze ui check-translation-completeness --language zh-CN
│ All files │ 988 │ 0 │ 988 │ 979 │ 9 │ 99.1% │ 0 │ 2 │
Some translations are not complete!
# PR head
$ breeze ui check-translation-completeness --language zh-CN
│ All files │ 988 │ 0 │ 988 │ 988 │ 0 │ 100.0% │ 0 │ 0 │
All translations are complete!
$ npx --yes pnpm@10.25.0 exec vitest run --exclude src/components/MonacoEditor/pythonFStrings.test.ts
Test Files 97 passed (97)
Tests 781 passed (781)
$ npx --yes pnpm@10.25.0 test src/components/MonacoEditor/pythonFStrings.test.ts
Test Files 1 passed (1)
Tests 12 passed (12)
$ npx --yes pnpm@10.25.0 build
transforming...✓ 5191 modules transformed.
✓ built in 10.76s
```
</details>
The full parallel Vitest run hit the existing 30-second Monaco import timeout; the isolated Monaco suite passed. Docker-backed UI E2E did not start because the image build could not resolve `deb.debian.org`.
`prek` pre-commit and manual stages passed.
## Risk
Only zh-CN resource files change. Runtime logic and English fallback behavior are unchanged.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes, GitHub Copilot CLI (GPT-5.6 Sol)
Generated-by: GitHub Copilot CLI (GPT-5.6 Sol) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Complete zh-CN Simplified Chinese translations [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #72789:
URL: https://github.com/apache/airflow/pull/72789#discussion_r3966916475
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/components.json:
##########
@@ -112,6 +112,10 @@
"file": "文件",
"location": "第 {{line}} 行，位于 {{name}}"
},
+ "passwordToggle": {
+ "hide": "隐藏值",
+ "show": "显示值"
Review Comment:
We drop 值 on our end. but either way works for me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Complete zh-CN Simplified Chinese translations [airflow]
Posted by "1fanwang (via GitHub)" <gi...@apache.org>.
1fanwang commented on PR #72789:
URL: https://github.com/apache/airflow/pull/72789#issuecomment-5599730527
cc @Lee-W for zh thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Complete zh-CN Simplified Chinese translations [airflow]
Posted by "1fanwang (via GitHub)" <gi...@apache.org>.
1fanwang commented on code in PR #72789:
URL: https://github.com/apache/airflow/pull/72789#discussion_r3967486847
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/components.json:
##########
@@ -112,6 +112,10 @@
"file": "文件",
"location": "第 {{line}} 行，位于 {{name}}"
},
+ "passwordToggle": {
+ "hide": "隐藏值",
+ "show": "显示值"
Review Comment:
Done in b7fae4b8e6. Dropped 值.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Complete zh-CN Simplified Chinese translations [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 merged PR #72789:
URL: https://github.com/apache/airflow/pull/72789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Complete zh-CN Simplified Chinese translations [airflow]
Posted by "1fanwang (via GitHub)" <gi...@apache.org>.
1fanwang commented on PR #72789:
URL: https://github.com/apache/airflow/pull/72789#issuecomment-5599728900
cc @vatsrahul1001 re: i18n phrases for Airflow 3.3.2 patch release (v3-3-test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Complete zh-CN Simplified Chinese translations [airflow]
Posted by "1fanwang (via GitHub)" <gi...@apache.org>.
1fanwang commented on code in PR #72789:
URL: https://github.com/apache/airflow/pull/72789#discussion_r3967035833
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/components.json:
##########
@@ -112,6 +112,10 @@
"file": "文件",
"location": "第 {{line}} 行，位于 {{name}}"
},
+ "passwordToggle": {
+ "hide": "隐藏值",
+ "show": "显示值"
Review Comment:
Thanks! agreed since it's more a name of the ACTION here, dropped the trailing 值 in https://github.com/apache/airflow/pull/72789/commits/ddd20cd3eed88213734a4a38ff8c0f5bb77eef64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Complete zh-CN Simplified Chinese translations [airflow]
Posted by "1fanwang (via GitHub)" <gi...@apache.org>.
1fanwang commented on code in PR #72789:
URL: https://github.com/apache/airflow/pull/72789#discussion_r3967486847
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/components.json:
##########
@@ -112,6 +112,10 @@
"file": "文件",
"location": "第 {{line}} 行，位于 {{name}}"
},
+ "passwordToggle": {
+ "hide": "隐藏值",
+ "show": "显示值"
Review Comment:
Done in b7fae4b8e6. Dropped 值.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org