You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 07:58:13 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25050: Upgrade FAB to 4.1.3 (#24884)
potiuk opened a new pull request, #25050:
URL: https://github.com/apache/airflow/pull/25050
no relevant changes found when comparing `airflow/www/fab_security` with FAB
see https://github.com/dpgaspar/Flask-AppBuilder/compare/v4.1.2...v4.1.3
(cherry picked from commit 01a5d8fe93a48883f4ae0d6ab65eeb82a30a09b9)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1191561320
Hey @jedcunningham @ephraimbuddy - I cherry-picked a number of breeze/ci changes (As again it was easier than trying to fix the related CI "problems" where changes in "main" have to be synced with the brenanch. Once it is green I will make a sync v2-3-stable to v2-3-test and then this one might finally succeed (and then I can re-cherry-pick it anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1184565829
Why aren't we just cherry-picking #24884 into v2-3-test then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1186209136
Hey @jedcunningham - was it good-enough explanation ? We need https://github.com/apache/airflow/pull/25056 merged for this one to succed as well as # https://github.com/apache/airflow/pull/25053. So I'd love to merge those to get this one merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1184315269
We need also #25056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1184124070
I need to upgraed FAB in v2-3-stable so that pull requests of users can be made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1188590229
Yep, makes sense. I'd personally prefer we cherry-pick and do an out-of-band v2-3-stable sync, but it ultimately doesn't really matter 🤷♂️.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #25050: Upgrade FAB to 4.1.3 (#24884)
URL: https://github.com/apache/airflow/pull/25050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1189268490
> Yep, makes sense. I'd personally prefer we cherry-pick and do an out-of-band v2-3-stable sync, but it ultimately doesn't really matter man_shrugging.
We can stil do it. I just want to have this PR green (and test that it CAN be done) and I can cherry-pick it directly later and merge to v2-3-stable, no problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1189258153
Let's see if we this will work now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1184620577
I am testing PR from a fork - that's why :).
Root cause is that there is a change #24961 coming which is coming from a user as PR (it's not really cherry-pickable as there were more changes in ther original PR and this one just brings DebugExecutor to be the same as in main).
And I already found that I need to add https://github.com/apache/airflow/pull/25056 and https://github.com/apache/airflow/pull/25053 to berged to main to make PRs to v2-3-stable work with the new selective checks and Python based breeze (so far we just tested that cherry-picks work fine).
I can eventually cherry-pick that one of course to v2-3-test, but then we would have to merge v2-3-test back to v2-3-stable so that users could make PRs to v2-3-stable.
I thought that we only merge v2-3-stable and v2-3-test when we relase, so I thought that this PR shoudl be merge to 'stable" (to enable other PRs), but I can cherry-pick and merge that one after I get a green PR here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25050: Upgrade FAB to 4.1.3 (#24884)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25050:
URL: https://github.com/apache/airflow/pull/25050#issuecomment-1206550016
OK. Finally I got it succeed, so I close this one and cherry-pick it instead :). We should be ok with handling PRs to v2-3 and v2-4 branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org