[GitHub] [nuttx-apps] davids5 commented on a diff in pull request #1481: nshlib/script: delete unnecessary log when missing script file

[GitBox <gi...@apache.org>]

davids5 commented on code in PR #1481:
URL: https://github.com/apache/nuttx-apps/pull/1481#discussion_r1058898922


##########
nshlib/nsh_script.c:
##########
@@ -194,7 +198,11 @@ int nsh_script(FAR struct nsh_vtbl_s *vtbl, FAR const FAR char *cmd,
 #ifdef CONFIG_NSH_ROMFSETC
 int nsh_sysinitscript(FAR struct nsh_vtbl_s *vtbl)
 {
-  return nsh_script_redirect(vtbl, "sysinit", NSH_SYSINITPATH);
+  /* Closing error log output for missing NSH_SYSINITPATH script file

Review Comment:
   I think this is clearer wording. But the formatting needs to be fixed



##########
nshlib/nsh_script.c:
##########
@@ -194,7 +198,11 @@ int nsh_script(FAR struct nsh_vtbl_s *vtbl, FAR const FAR char *cmd,
 #ifdef CONFIG_NSH_ROMFSETC
 int nsh_sysinitscript(FAR struct nsh_vtbl_s *vtbl)
 {
-  return nsh_script_redirect(vtbl, "sysinit", NSH_SYSINITPATH);
+  /* Closing error log output for missing NSH_SYSINITPATH script file

Review Comment:
   ```suggestion
     /* Since most existing systems only use the NSH_INITPATH script file. Do not log error output for a missing 
      * NSH_SYSINITPATH script file.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org