You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LucaCappelletti94 (via GitHub)" <gi...@apache.org> on 2026/10/17 09:55:02 UTC
[PR] Deny `clippy::allow_attributes` and `allow_attributes_without_reason` [datafusion-sqlparser-rs]
LucaCappelletti94 opened a new pull request, #2653:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2653
Every lint suppression becomes `#[expect(..., reason = "...")]`. An `expect` fails the build once the lint it silences stops firing, so stale suppressions get removed instead of lingering. Converting the existing ones found four stale suppressions and two that the crate-level one already covered, which this removes, and two test sites that are simpler fixed than suppressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Deny `clippy::allow_attributes` and `allow_attributes_without_reason` [datafusion-sqlparser-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2653:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2653#issuecomment-6232536868
## [Codecov](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2653?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.24%. Comparing base ([`5a975d0`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/5a975d0f4e7dc22b0226eaa8facc12a2fab1aca1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`991dd51`](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/commit/991dd51add547d1ac728bd9fcb63dafb19ebb9b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2653 +/- ##
=======================================
Coverage 81.24% 81.24%
=======================================
Files 42 42
Lines 33901 33901
Branches 33901 33901
=======================================
Hits 27543 27543
Misses 2792 2792
Partials 3566 3566
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion-sqlparser-rs/pull/2653?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Deny `clippy::allow_attributes` and `allow_attributes_without_reason` [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 merged PR #2653:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Deny `clippy::allow_attributes` and `allow_attributes_without_reason` [datafusion-sqlparser-rs]
Posted by "LucaCappelletti94 (via GitHub)" <gi...@apache.org>.
LucaCappelletti94 commented on PR #2653:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2653#issuecomment-6232779012
Will proceed to merge this one in if that is okay.
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Deny `clippy::allow_attributes` and `allow_attributes_without_reason` [datafusion-sqlparser-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2653:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2653#issuecomment-6232522655
<!-- dialect-labeler -->
No dialect label was applied because the title does not name a SQL dialect.
If this change targets one or more dialects, edit the title to `<Dialect>[, <Dialect>]: <description>`, add a `Dialects: <Dialect>[, <Dialect>]` line to the description, or reply with one. Reply `Dialects: none` if the change is dialect-agnostic.
Changed files touch Snowflake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org