You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@hotwaxmedia.com> on 2012/02/27 11:34:30 UTC
Re: svn commit: r1294095 - /ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java
Hi Jacques,
why are you still backporting fixes to the 09.04 branch? this is the second one you commit after the release 09.04.02 has beed released and there seems to be general consensus to consider it the last release in the branch.
Of course we can change decision and plan for another release and continue to backport patches if you feel the need for this... but if we don't then these fixes will never be released.
Jacopo
On Feb 27, 2012, at 11:26 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Mon Feb 27 10:26:46 2012
> New Revision: 1294095
>
> URL: http://svn.apache.org/viewvc?rev=1294095&view=rev
> Log:
> A patch from Chatree Srichart "OrderListState needs to be Serializable for clustering" https://issues.apache.org/jira/browse/OFBIZ-4660
>
> OrderListState is to be set to session, so it needs to be Serializable for clustering.
>
> Modified:
> ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java
>
> Modified: ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java?rev=1294095&r1=1294094&r2=1294095&view=diff
> ==============================================================================
> --- ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java (original)
> +++ ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java Mon Feb 27 10:26:46 2012
> @@ -18,13 +18,26 @@
> */
> package org.ofbiz.order.order;
>
> -import java.util.*;
> -import javax.servlet.http.*;
> -import javolution.util.*;
> -import org.ofbiz.base.util.*;
> -import org.ofbiz.entity.*;
> -import org.ofbiz.entity.condition.*;
> -import org.ofbiz.entity.util.*;
> +import java.io.Serializable;
> +import java.util.ArrayList;
> +import java.util.Iterator;
> +import java.util.List;
> +import java.util.Map;
> +
> +import javax.servlet.http.HttpServletRequest;
> +import javax.servlet.http.HttpSession;
> +
> +import javolution.util.FastMap;
> +
> +import org.ofbiz.base.util.Debug;
> +import org.ofbiz.base.util.UtilMisc;
> +import org.ofbiz.base.util.UtilValidate;
> +import org.ofbiz.entity.GenericDelegator;
> +import org.ofbiz.entity.GenericEntityException;
> +import org.ofbiz.entity.condition.EntityCondition;
> +import org.ofbiz.entity.condition.EntityOperator;
> +import org.ofbiz.entity.util.EntityFindOptions;
> +import org.ofbiz.entity.util.EntityListIterator;
>
> /**
> * Session object for keeping track of the list of orders.
> @@ -40,7 +53,8 @@ import org.ofbiz.entity.util.*;
> * objects, including Pagination. Think about design
> * patterns in Fowler.
> */
> -public class OrderListState {
> +@SuppressWarnings("serial")
> +public class OrderListState implements Serializable {
>
> public static final String module = OrderListState.class.getName();
> public static final String SESSION_KEY = "__ORDER_LIST_STATUS__";
>
>
Re: svn commit: r1294095 - /ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Oops, indeed forgot that 09.04.02 would be the last...
I think I will stop then. It's anyway more and more difficult which means that it's time to stop
Jacques
From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
> Hi Jacques,
>
> why are you still backporting fixes to the 09.04 branch? this is the second one you commit after the release 09.04.02 has beed
> released and there seems to be general consensus to consider it the last release in the branch.
> Of course we can change decision and plan for another release and continue to backport patches if you feel the need for this...
> but if we don't then these fixes will never be released.
>
> Jacopo
>
> On Feb 27, 2012, at 11:26 AM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Mon Feb 27 10:26:46 2012
>> New Revision: 1294095
>>
>> URL: http://svn.apache.org/viewvc?rev=1294095&view=rev
>> Log:
>> A patch from Chatree Srichart "OrderListState needs to be Serializable for clustering"
>> https://issues.apache.org/jira/browse/OFBIZ-4660
>>
>> OrderListState is to be set to session, so it needs to be Serializable for clustering.
>>
>> Modified:
>> ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java
>>
>> Modified: ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java?rev=1294095&r1=1294094&r2=1294095&view=diff
>> ==============================================================================
>> --- ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java (original)
>> +++ ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java Mon Feb 27 10:26:46 2012
>> @@ -18,13 +18,26 @@
>> */
>> package org.ofbiz.order.order;
>>
>> -import java.util.*;
>> -import javax.servlet.http.*;
>> -import javolution.util.*;
>> -import org.ofbiz.base.util.*;
>> -import org.ofbiz.entity.*;
>> -import org.ofbiz.entity.condition.*;
>> -import org.ofbiz.entity.util.*;
>> +import java.io.Serializable;
>> +import java.util.ArrayList;
>> +import java.util.Iterator;
>> +import java.util.List;
>> +import java.util.Map;
>> +
>> +import javax.servlet.http.HttpServletRequest;
>> +import javax.servlet.http.HttpSession;
>> +
>> +import javolution.util.FastMap;
>> +
>> +import org.ofbiz.base.util.Debug;
>> +import org.ofbiz.base.util.UtilMisc;
>> +import org.ofbiz.base.util.UtilValidate;
>> +import org.ofbiz.entity.GenericDelegator;
>> +import org.ofbiz.entity.GenericEntityException;
>> +import org.ofbiz.entity.condition.EntityCondition;
>> +import org.ofbiz.entity.condition.EntityOperator;
>> +import org.ofbiz.entity.util.EntityFindOptions;
>> +import org.ofbiz.entity.util.EntityListIterator;
>>
>> /**
>> * Session object for keeping track of the list of orders.
>> @@ -40,7 +53,8 @@ import org.ofbiz.entity.util.*;
>> * objects, including Pagination. Think about design
>> * patterns in Fowler.
>> */
>> -public class OrderListState {
>> +@SuppressWarnings("serial")
>> +public class OrderListState implements Serializable {
>>
>> public static final String module = OrderListState.class.getName();
>> public static final String SESSION_KEY = "__ORDER_LIST_STATUS__";
>>
>>
>
>