[GitHub] [pulsar] RobertIndie commented on a diff in pull request #14887: [feature][admin] Support reset cluster replicator cursor

[GitBox <gi...@apache.org>]

RobertIndie commented on code in PR #14887:
URL: https://github.com/apache/pulsar/pull/14887#discussion_r865877966


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -2278,89 +2279,60 @@ private void internalCreateSubscriptionForNonPartitionedTopic(
         });
     }
 
-    protected void internalResetCursorOnPosition(AsyncResponse asyncResponse, String subName, boolean authoritative,
+    protected CompletableFuture<Void> internalResetCursorOnPosition(String name, boolean authoritative,

Review Comment:
   It doesn't look like to have changed. Am I missing something?



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java:
##########
@@ -771,10 +784,55 @@ public boolean isConnected() {
         return producer != null && producer.isConnected();
     }
 
+    @Override
+    public CompletableFuture<Void> resetCursor(Position position) {
+        CURSOR_RESETTING_UPDATER.set(this, TRUE);

Review Comment:
   It's not deleted. Did you update your codes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org