[GitHub] cloudstack pull request #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails f...

[jburwell <gi...@git.apache.org>]

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/798#discussion_r79315948
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java ---
    @@ -1464,4 +1448,55 @@ private String deleteDir(String dir) {
         private static String getVolumeRelativeDirInSecStroage(long volumeId) {
             return "volumes/" + volumeId;
         }
    +
    +    /**
    +     * This method is to check if a given TaskInfo Object is valid( and has name and entity name assigned).It return true if TaskInfo Object is valid and false otherwise.
    +     *
    +     * @param TaskInfo
    +     *        info
    +     * @return boolean(true or false)
    +     **/
    +    private boolean isvalidTaskInfoObj(TaskInfo info){
    --- End diff --
    
    Why is this method necessary?  It is a one line boolean result that is called from one place.  It seems to obfuscate more than clarify.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---