You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Mike Percy (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/23 02:48:39 UTC
[kudu-CR] Fix integer overflow in remote_bootstrap_client-test
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/1883
to review the following change.
Change subject: Fix integer overflow in remote_bootstrap_client-test
......................................................................
Fix integer overflow in remote_bootstrap_client-test
Fixes the following Clang warning:
[823/936] Building CXX object src/kudu/tserver/CMakeFiles/remote_bootstrap_client-test.dir/remote_bootstrap_client-test.cc.o
src/kudu/tserver/remote_bootstrap_client-test.cc:149:29: warning: implicit conversion from 'unsigned long' to 'const int' changes value from 18446744073709551615 to -1 [-Wconstant-conversion]
const int kDataTotalLen = std::numeric_limits<uint64_t>::max();
~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Change-Id: Ia8aadd7ff2072fb45e2c754885a79fada54efd53
---
M src/kudu/tserver/remote_bootstrap_client-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/1883/1
--
To view, visit http://gerrit.cloudera.org:8080/1883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8aadd7ff2072fb45e2c754885a79fada54efd53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans