You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/04/21 00:19:15 UTC

Review Request 33374: Resuming blocked updates on restart.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33374/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Bugs: AURORA-1285
    https://issues.apache.org/jira/browse/AURORA-1285


Repository: aurora


Description
-------

Changing the `systemResume()` to properly re-initialize `PulseState` for all active coordinated updates.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ac15217fa9eb63e7292d23702e37c6fd194fbaed 
  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 74e915ce678855aa2a2ae44ff59cfba259447796 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java dd4c94097161477e8161fb7e440e4c41e2a61f21 

Diff: https://reviews.apache.org/r/33374/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko


Re: Review Request 33374: Resuming blocked updates on restart.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33374/#review81046
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On April 20, 2015, 10:19 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33374/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 10:19 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1285
>     https://issues.apache.org/jira/browse/AURORA-1285
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Changing the `systemResume()` to properly re-initialize `PulseState` for all active coordinated updates.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ac15217fa9eb63e7292d23702e37c6fd194fbaed 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 74e915ce678855aa2a2ae44ff59cfba259447796 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java dd4c94097161477e8161fb7e440e4c41e2a61f21 
> 
> Diff: https://reviews.apache.org/r/33374/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Re: Review Request 33374: Resuming blocked updates on restart.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33374/#review80852
-----------------------------------------------------------

Ship it!


Master (4b90339) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 20, 2015, 10:19 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33374/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 10:19 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1285
>     https://issues.apache.org/jira/browse/AURORA-1285
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Changing the `systemResume()` to properly re-initialize `PulseState` for all active coordinated updates.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ac15217fa9eb63e7292d23702e37c6fd194fbaed 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 74e915ce678855aa2a2ae44ff59cfba259447796 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java dd4c94097161477e8161fb7e440e4c41e2a61f21 
> 
> Diff: https://reviews.apache.org/r/33374/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>