You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "limfriend (GitHub)" <gi...@apache.org> on 2019/01/11 13:47:05 UTC
[GitHub] [incubator-dubbo] limfriend opened issue #3209: will dubbo
support opentracing? when?
open tracing become more and more popular. we can find a lot of framework which is support opentracing, e.g grpc, thrift, okhttp, kafka, redis, jdbc, spring boot..
https://github.com/opentracing-contrib?utf8=%E2%9C%93&q=&type=&language=java
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] maxiaoguang64 commented on issue #3209:
will dubbo support opentracing? when?
Posted by "maxiaoguang64 (GitHub)" <gi...@apache.org>.
@ralf0131 I want to add a sub project dubbo-filter-opentracing in dubbo-filter.
if user want to use trace implement opentracing, only need to call GlobalTracer.register(tracer).
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3209: will
dubbo support opentracing? when?
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Hi,
Thanks for raising this issue, for now Dubbo support tracing framework like Zipkin, Skywalking and Spring Cloud Sleuth, I think supporting opentracing should be as straight-forward as they are.
The principal here for Dubbo is that we should embrace the standards. If you or someone would like to contribute, we will be very happy.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3209: will
dubbo support opentracing? when?
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
@maxiaoguang64 I've replied your email. I think you can go ahead with your implementation. What need to be discussed is where should the code be placed.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3209: will
dubbo support opentracing? when?
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
@maxiaoguang64 Great, please feel feel to go ahead.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] maxiaoguang64 commented on issue #3209:
will dubbo support opentracing? when?
Posted by "maxiaoguang64 (GitHub)" <gi...@apache.org>.
@ralf0131 It's only a filter that implement org.apache.dubbo.rpc.Filter and use opentracing api.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] maxiaoguang64 commented on issue #3209:
will dubbo support opentracing? when?
Posted by "maxiaoguang64 (GitHub)" <gi...@apache.org>.
@ralf0131 I send a mail to discuss with this, but i didn't get any reply.
can we disscus with github?
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3209: will
dubbo support opentracing? when?
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
@maxiaoguang64 Please ahead with your implementation, about where should the code go, I am not quite sure we should put that in the core Dubbo repository or in external repository (spring-cloud-sleuth and skywalking support code are not in Dubbo repository), would you please subscribe and send email to dev@dubbo.apache.org to discuss with the community?
You can refer to this [guide](http://dubbo.apache.org/zh-cn/docs/developers/contributor-guide/mailing-list-subscription-guide_dev.html) to subscribe the mailing list.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 commented on issue #3209: will
dubbo support opentracing? when?
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
@maxiaoguang64 Please ahead with your implementation, about where should the code go, I am not quite sure we should put that in the core Dubbo repository in external repository, would you please subscribe and send email to dev@dubbo.apache.org to discuss with the community?
You can refer to this [guide](http://dubbo.apache.org/zh-cn/docs/developers/contributor-guide/mailing-list-subscription-guide_dev.html) to subscribe the mailing list.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] maxiaoguang64 commented on issue #3209:
will dubbo support opentracing? when?
Posted by "maxiaoguang64 (GitHub)" <gi...@apache.org>.
I have some experience in opentracing.
I want to try it.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] Kiddinglife commented on issue #3209: will
dubbo support opentracing? when?
Posted by "Kiddinglife (GitHub)" <gi...@apache.org>.
@maxiaoguang I believe so, mate. I will try it when you are done. Lol.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] Kiddinglife commented on issue #3209: will
dubbo support opentracing? when?
Posted by "Kiddinglife (GitHub)" <gi...@apache.org>.
@limfriend
Hi mate,
the current tracing of dubbo is good enough in most of cases.
Can you please highlight the reason why you desire to move to opentracing? Does it have some features that overwheel others?
regards.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3209 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org