[GitHub] [arrow] sahil1105 commented on a change in pull request #10088: ARROW-10675 [C++][Python] Support AWS S3 Web identity credentials

[GitBox <gi...@apache.org>]

sahil1105 commented on a change in pull request #10088:
URL: https://github.com/apache/arrow/pull/10088#discussion_r624508726



##########
File path: python/pyarrow/_s3fs.pyx
##########
@@ -74,6 +74,13 @@ cdef class S3FileSystem(FileSystem):
         Whether to connect anonymously if access_key and secret_key are None.
         If true, will not attempt to look up credentials using standard AWS
         configuration methods.
+    use_web_identity: boolean, default False
+        Whether to connect using an assumed role authenticated using
+        a web identity token. The required settings are derived from
+        environment variables such as AWS_ROLE_ARN,
+        AWS_WEB_IDENTITY_TOKEN_FILE and AWS_ROLE_SESSION_NAME.
+        If true, will not attempt to look up credentials using other
+        AWS configuration methods.

Review comment:
       @pitrou That makes sense to me as well.
   I think it might be better to do that in a separate PR though (to keep the scope of this one limited).
   Let me know.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org