You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by chengxiang li <ch...@intel.com> on 2014/12/04 10:22:20 UTC
Review Request 28699: HIVE-8783 Create some tests that use Spark
counter for stats collection [Spark Branch]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28699/
-----------------------------------------------------------
Review request for hive and Xuefu Zhang.
Bugs: HIVE-8783
https://issues.apache.org/jira/browse/HIVE-8783
Repository: hive-git
Description
-------
Hive already has stats_counter.q and stats_counter_partitioned.q for unit test of table statistic collection on Counter. stats_counter.q has enabled yet, I enable stats_counter_partitioned.q in this patch.
Diffs
-----
itests/src/test/resources/testconfiguration.properties 09c667e
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 30b7632
ql/src/test/results/clientpositive/spark/stats_counter_partitioned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/28699/diff/
Testing
-------
Thanks,
chengxiang li
Re: Review Request 28699: HIVE-8783 Create some tests that use Spark
counter for stats collection [Spark Branch]
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28699/#review63954
-----------------------------------------------------------
Ship it!
Ship It!
- Xuefu Zhang
On Dec. 5, 2014, 2:05 a.m., chengxiang li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28699/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 2:05 a.m.)
>
>
> Review request for hive and Xuefu Zhang.
>
>
> Bugs: HIVE-8783
> https://issues.apache.org/jira/browse/HIVE-8783
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive already has stats_counter.q and stats_counter_partitioned.q for unit test of table statistic collection on Counter. stats_counter.q has enabled yet, I enable stats_counter_partitioned.q in this patch.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 09c667e
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 30b7632
> ql/src/test/results/clientpositive/spark/stats_counter_partitioned.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28699/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> chengxiang li
>
>
Re: Review Request 28699: HIVE-8783 Create some tests that use Spark
counter for stats collection [Spark Branch]
Posted by chengxiang li <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28699/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 2:05 a.m.)
Review request for hive and Xuefu Zhang.
Bugs: HIVE-8783
https://issues.apache.org/jira/browse/HIVE-8783
Repository: hive-git
Description
-------
Hive already has stats_counter.q and stats_counter_partitioned.q for unit test of table statistic collection on Counter. stats_counter.q has enabled yet, I enable stats_counter_partitioned.q in this patch.
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties 09c667e
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 30b7632
ql/src/test/results/clientpositive/spark/stats_counter_partitioned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/28699/diff/
Testing
-------
Thanks,
chengxiang li
Re: Review Request 28699: HIVE-8783 Create some tests that use Spark
counter for stats collection [Spark Branch]
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28699/#review63852
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java
<https://reviews.apache.org/r/28699/#comment106158>
Name this variable as "partitions" might be a little confusing. Same as below "partition". Maybe we can call them as partitionSpecs and partitionSpec respectively.
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java
<https://reviews.apache.org/r/28699/#comment106159>
"list" seems too general to be meaningful.
- Xuefu Zhang
On Dec. 4, 2014, 9:22 a.m., chengxiang li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28699/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 9:22 a.m.)
>
>
> Review request for hive and Xuefu Zhang.
>
>
> Bugs: HIVE-8783
> https://issues.apache.org/jira/browse/HIVE-8783
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive already has stats_counter.q and stats_counter_partitioned.q for unit test of table statistic collection on Counter. stats_counter.q has enabled yet, I enable stats_counter_partitioned.q in this patch.
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties 09c667e
> ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 30b7632
> ql/src/test/results/clientpositive/spark/stats_counter_partitioned.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28699/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> chengxiang li
>
>