[GitHub] hopefulnick opened a new pull request #2253: [Dubbo-1728] System property dubbo.service.delay invalid

[GitBox <gi...@apache.org>]

hopefulnick opened a new pull request #2253: [Dubbo-1728] System property dubbo.service.delay invalid 
URL: https://github.com/apache/incubator-dubbo/pull/2253
 
 
   ## What is the purpose of the change
   
   Fix Issue #1728
   
   ## Brief changelog
   File Changed:
   dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
   
   Main Change:
   Move the invoke of Method appendProperties(this) before the null test of 'delay' parameter
   
   Aim:
   1 Ensure the order of the properties mapping，JVM's > XML's > Properties File's.
   2 Do the "delay"'s null test after JVM parameters' loading.
   
   ## Verifying this change
   Changes have been tested with different cases:
   1 The order of properties loading
   2 The override of different mapping methods
   3 The correctness of properties loading
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org