You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/11/04 05:09:32 UTC

[jclouds-labs-google] Cleanup ListPage in google apis. (#75)

Be consistent, but recognize that google storage has a list of prefixes, where google compute engine does not.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs-google adrian.clean-listpage

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/75

-- Commit Summary --

  * Cleanup ListPage in google apis.

-- File Changes --

    M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListPage.java (15)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineFallbacks.java (2)
    M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/ListPage.java (18)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/HttpHealthCheckApiLiveTest.java (4)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiExpectTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/TargetPoolApiLiveTest.java (4)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTypeListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseForwardingRuleListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseGlobalOperationListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseHttpHealthCheckListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseNetworkListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRouteListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseSnapshotListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseTargetPoolListTest.java (3)
    M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneListTest.java (3)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/75.patch
https://github.com/jclouds/jclouds-labs-google/pull/75.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/75

Re: [jclouds-labs-google] Cleanup ListPage in google apis. (#75)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-google #1614](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1614/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/75#issuecomment-61591441

Re: [jclouds-labs-google] Cleanup ListPage in google apis. (#75)

Posted by Ignasi Barrera <no...@github.com>.
+1

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/75#issuecomment-61659705

Re: [jclouds-labs-google] Cleanup ListPage in google apis. (#75)

Posted by Adrian Cole <no...@github.com>.
picked into master

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/75#issuecomment-61667512

Re: [jclouds-labs-google] Cleanup ListPage in google apis. (#75)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #210](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/210/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/75#issuecomment-61591225