You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "quinnj (via GitHub)" <gi...@apache.org> on 2023/06/13 23:09:16 UTC
[GitHub] [arrow-julia] quinnj opened a new pull request, #469: Use wkspawn from ConcurrentUtilities instead of Threads.spawn
quinnj opened a new pull request, #469:
URL: https://github.com/apache/arrow-julia/pull/469
Should fix #336.
For more context, see the [same fix](https://github.com/JuliaData/CSV.jl/commit/077e177e359c0b58e2d6db0b660a235a2ee54228) we made for this in CSV.jl.
Basically, objects interpolated into or returned from spawned tasks can be unexpectedly kept alive long after the task has finished and the object should have been garbage-collected due to individual threads holding the most recent task as a reference. Using `@wkspawn` ensures tasks themselves don't hold references to any of these once they're done executing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] codecov-commenter commented on pull request #469: Use wkspawn from ConcurrentUtilities instead of Threads.spawn
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #469:
URL: https://github.com/apache/arrow-julia/pull/469#issuecomment-1590179173
## [Codecov](https://app.codecov.io/gh/apache/arrow-julia/pull/469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#469](https://app.codecov.io/gh/apache/arrow-julia/pull/469?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (61bee0f) into [main](https://app.codecov.io/gh/apache/arrow-julia/commit/ce8b581a7d5b53f88d48ef651a19b02425af6e21?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ce8b581) will **decrease** coverage by `82.49%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 87.57% 5.09% -82.49%
==========================================
Files 26 25 -1
Lines 3276 3199 -77
==========================================
- Hits 2869 163 -2706
- Misses 407 3036 +2629
```
| [Impacted Files](https://app.codecov.io/gh/apache/arrow-julia/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [src/append.jl](https://app.codecov.io/gh/apache/arrow-julia/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2FwcGVuZC5qbA==) | `0.00% <0.00%> (-92.05%)` | :arrow_down: |
| [src/table.jl](https://app.codecov.io/gh/apache/arrow-julia/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3RhYmxlLmps) | `0.00% <0.00%> (-92.50%)` | :arrow_down: |
| [src/write.jl](https://app.codecov.io/gh/apache/arrow-julia/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3dyaXRlLmps) | `0.00% <0.00%> (-97.86%)` | :arrow_down: |
... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/arrow-julia/pull/469/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-julia] quinnj merged pull request #469: Use wkspawn from ConcurrentUtilities instead of Threads.spawn
Posted by "quinnj (via GitHub)" <gi...@apache.org>.
quinnj merged PR #469:
URL: https://github.com/apache/arrow-julia/pull/469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org