You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/08/08 01:05:06 UTC

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?

- Kevin Sweeney


On July 30, 2014, 1:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Kevin Sweeney <ke...@apache.org>.

> On Aug. 7, 2014, 4:05 p.m., Kevin Sweeney wrote:
> > Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?

Bill: I'll be out on vacation starting tomorrow, would you mind committing this if dhamon sends an updated patch?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


On July 30, 2014, 1:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Dominic Hamon <dh...@twopensource.com>.

> On Aug. 7, 2014, 4:05 p.m., Kevin Sweeney wrote:
> > Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?
> 
> Kevin Sweeney wrote:
>     Bill: I'll be out on vacation starting tomorrow, would you mind committing this if dhamon sends an updated patch?
> 
> Bill Farner wrote:
>     Sure thing.  You can collect your review delay demerits on Monday.

0.20 has not been cut or released yet.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


On July 30, 2014, 1:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

Posted by Bill Farner <wf...@apache.org>.

> On Aug. 7, 2014, 11:05 p.m., Kevin Sweeney wrote:
> > Sorry for the turnaround, would you mind rebasing again. Looks like mesos-0.20.0 is out so maybe we should discard this review and go straight to that?
> 
> Kevin Sweeney wrote:
>     Bill: I'll be out on vacation starting tomorrow, would you mind committing this if dhamon sends an updated patch?

Sure thing.  You can collect your review delay demerits on Monday.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review49964
-----------------------------------------------------------


On July 30, 2014, 8:25 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23348/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 8:25 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-579
>     https://issues.apache.org/jira/browse/AURORA-579
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrading Mesos version from 0.18.0 to 0.19.0
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f 
>   examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 
> 
> Diff: https://reviews.apache.org/r/23348/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>