[jira] [Commented] (PIG-1926) Sample/Limit should take scalar

["Thejas M Nair (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058984#comment-13058984 ] 

Thejas M Nair commented on PIG-1926:
------------------------------------

PIG-1926.11.patch - Sample also needs a check similar to that for Limit in LimitVariableValidator, to give error for statements such as - "f = sample l $0;"
LimitVariableValidator could be replaced by new class that does the check for both limit and sample operations. Can you also add a negative test case for this? Everything else looks good. 

> Sample/Limit should take scalar
> -------------------------------
>
>                 Key: PIG-1926
>                 URL: https://issues.apache.org/jira/browse/PIG-1926
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Daniel Dai
>            Assignee: Gianmarco De Francisci Morales
>              Labels: gsoc2011
>         Attachments: PIG-1926.10.patch, PIG-1926.11.patch, PIG-1926.7.patch, PIG-1926.8.patch, PIG-1926.9.patch, PIG-1926.patch, PIG-1926.patch, PIG-1926.patch, PIG-1926.patch, PIG-1926.patch, PIG-1926.patch
>
>
> Currently, Limit, Sample only takes a constant. It would be better we can use a scalar in the place of constant. Eg:
> {code}
> a = load 'a.txt';
> b = group a all;
> c = foreach b generate COUNT(a) as sum;
> d = order a by $0;
> e = limit d c.sum/100;
> {code}
> This is a candidate project for Google summer of code 2011. More information about the program can be found at http://wiki.apache.org/pig/GSoc2011

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira