[jira] [Commented] (MPOM-211) Add (server-)id property to Scm model

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPOM-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667614#comment-16667614 ] 

ASF GitHub Bot commented on MPOM-211:
-------------------------------------

silkentrance opened a new pull request #190: MPOM-211
URL: https://github.com/apache/maven/pull/190
 
 
   - add id property to Scm model
   - add hashCode() and equals() methods to Scm model
   - add additional tests to Scm model
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
    - [x] The changes are trivial and do not require to run the Core IT test suite?
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add (server-)id property to Scm model
> -------------------------------------
>
>                 Key: MPOM-211
>                 URL: https://issues.apache.org/jira/browse/MPOM-211
>             Project: Maven POMs
>          Issue Type: Improvement
>            Reporter: Carsten Klein
>            Priority: Major
>
> The maven-release plugin introduces the IdentifiedScm which includes the id property, allowing the user to specify a server id for use with the lookup of credentials that can be set securely in the maven settings.xml.
> This is a nice feature to have on the the original Scm model as well and it will leverage some security issues that we have with multiple other plugins operating on the Scm model.
> Currently, the user is required to specify the credentials either via the command line or directly in the plugin configuration in the pom, or externally, using third party tools.
> And the Scm model should also implement the hashCode and equals() methods.
> Of course this will require also changes to the existing Scm plugins so that they can make use of the new feature. Also, the maven-release plugin can be somewhat simplified by this change.
>  
> QUESTION: should this then still be the POM version 4.0.0 or is this then 4.1.0?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)