You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/14 15:56:52 UTC

[GitHub] [hudi] wangxianghu opened a new pull request #1734: [MINOR] fix checkstyle

wangxianghu opened a new pull request #1734:
URL: https://github.com/apache/hudi/pull/1734


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *fix checkstyle*
   
   ## Brief change log
   
   *fix checkstyle*
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #1734: [MINOR] fix checkstyle

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1734:
URL: https://github.com/apache/hudi/pull/1734#issuecomment-644164192


   @wangxianghu vc is right, sorry I did not check the content of the PR. We should align some basic information.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter edited a comment on pull request #1734: [MINOR] fix checkstyle

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1734:
URL: https://github.com/apache/hudi/pull/1734#issuecomment-643790963


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=h1) Report
   > Merging [#1734](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/ede6c9bda4dba8a9981252bd05f0725ff1024b95&el=desc) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/1734/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1734   +/-   ##
   =========================================
     Coverage     18.14%   18.14%           
     Complexity      859      859           
   =========================================
     Files           352      352           
     Lines         15411    15411           
     Branches       1525     1525           
   =========================================
     Hits           2797     2797           
     Misses        12256    12256           
     Partials        358      358           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `65.78% <ø> (ø)` | `6.00 <0.00> (ø)` | |
   | [.../apache/hudi/client/AbstractHoodieWriteClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `52.83% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/client/CompactionAdminClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0NvbXBhY3Rpb25BZG1pbkNsaWVudC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../java/org/apache/hudi/client/HoodieReadClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZVJlYWRDbGllbnQuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/hudi/client/utils/ClientUtils.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL0NsaWVudFV0aWxzLmphdmE=) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/execution/LazyInsertIterable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhlY3V0aW9uL0xhenlJbnNlcnRJdGVyYWJsZS5qYXZh) | `70.58% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...che/hudi/index/simple/HoodieGlobalSimpleIndex.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvc2ltcGxlL0hvb2RpZUdsb2JhbFNpbXBsZUluZGV4LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/table/HoodieCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllQ29weU9uV3JpdGVUYWJsZS5qYXZh) | `7.14% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/table/HoodieMergeOnReadTable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllTWVyZ2VPblJlYWRUYWJsZS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGUuamF2YQ==) | `40.15% <ø> (ø)` | `22.00 <0.00> (ø)` | |
   | ... and [44 more](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=footer). Last update [ede6c9b...9faa7c1](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #1734: [MINOR] fix checkstyle

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1734:
URL: https://github.com/apache/hudi/pull/1734#issuecomment-644038349


   hi @yanghua please take a look when free :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu commented on pull request #1734: [MINOR] fix checkstyle

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #1734:
URL: https://github.com/apache/hudi/pull/1734#issuecomment-644186581


   > @wangxianghu vc is right, sorry I did not check the content of the PR. We should align some basic information.
   
   @yanghua yes, if we can't get consistently format from IDE, then fixing checkstyle makes no sense.
   @vinothchandar thanks for reminding. let's discuss in the mail list first, and deal with it later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] wangxianghu closed pull request #1734: [MINOR] fix checkstyle

Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #1734:
URL: https://github.com/apache/hudi/pull/1734


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codecov-commenter commented on pull request #1734: [MINOR] fix checkstyle

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1734:
URL: https://github.com/apache/hudi/pull/1734#issuecomment-643790963


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=h1) Report
   > Merging [#1734](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/ede6c9bda4dba8a9981252bd05f0725ff1024b95&el=desc) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/1734/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #1734   +/-   ##
   =========================================
     Coverage     18.14%   18.14%           
     Complexity      859      859           
   =========================================
     Files           352      352           
     Lines         15411    15411           
     Branches       1525     1525           
   =========================================
     Hits           2797     2797           
     Misses        12256    12256           
     Partials        358      358           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `65.78% <ø> (ø)` | `6.00 <0.00> (ø)` | |
   | [.../apache/hudi/client/AbstractHoodieWriteClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `52.83% <ø> (ø)` | `13.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/client/CompactionAdminClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0NvbXBhY3Rpb25BZG1pbkNsaWVudC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../java/org/apache/hudi/client/HoodieReadClient.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZVJlYWRDbGllbnQuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/hudi/client/utils/ClientUtils.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL0NsaWVudFV0aWxzLmphdmE=) | `75.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/execution/LazyInsertIterable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhlY3V0aW9uL0xhenlJbnNlcnRJdGVyYWJsZS5qYXZh) | `70.58% <ø> (ø)` | `8.00 <0.00> (ø)` | |
   | [...che/hudi/index/simple/HoodieGlobalSimpleIndex.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaW5kZXgvc2ltcGxlL0hvb2RpZUdsb2JhbFNpbXBsZUluZGV4LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/table/HoodieCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllQ29weU9uV3JpdGVUYWJsZS5qYXZh) | `7.14% <ø> (ø)` | `4.00 <0.00> (ø)` | |
   | [.../org/apache/hudi/table/HoodieMergeOnReadTable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllTWVyZ2VPblJlYWRUYWJsZS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGUuamF2YQ==) | `40.15% <ø> (ø)` | `22.00 <0.00> (ø)` | |
   | ... and [44 more](https://codecov.io/gh/apache/hudi/pull/1734/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=footer). Last update [ede6c9b...9faa7c1](https://codecov.io/gh/apache/hudi/pull/1734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org