You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by wangrenlei <gi...@git.apache.org> on 2017/03/19 03:05:03 UTC
[GitHub] nifi pull request #1604: NIFI-3603：localization needed
GitHub user wangrenlei opened a pull request:
https://github.com/apache/nifi/pull/1604
NIFI-3603\uff1alocalization needed
NIFI-3603\uff1aLocalization needed
I have completed localization changes including Chinese and English, as well as Japanese part of the localized changes, only need
(1) in nifi-web-ui \ src \ main \ java add the local language properties file, and then specify it in web.xml
(2) Add an array of native languages to nifi-web-ui \ src \ main \ webapp \ js \ nf \ globalization \ resources.js and point the parameter locale to it
It can help NIFI developers around the world more convenient to use it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangrenlei/nifi-1 NIFI-3603
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1604
----
commit 2d0d09591263c0878f9c082637d6bbd7978b6c66
Author: WangJian <19...@qq.com>
Date: 2017-03-19T01:45:11Z
NIFI-3603:Updated nifi-web-ui POM to add localization files
commit abf1ed3cd63b89c06945273783c7826ba6d7f9c7
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:03:24Z
NIFI-3603:Updated WEB-INF to add jstl dependencies to the jsp files and the jstl configuration in web.xml
commit daa085203982d0b7d2fea71fd8856e23f5cc9839
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:12:27Z
Updated js directory to add *.js localized changes and add gloabalization directory
commit 2da95e0d39d03bb0ba2596c0733071b4ceb86992
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:13:53Z
Updated js directory to add *.js localized changes and add gloabalization directory
commit c55c9dfbe2761ac035ac6a5ae10161dda9d80331
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:13:53Z
NIFI-3603:Updated js directory to add *.js localized changes and add gloabalization directory
commit c28f28098d91e8181460661bebc9a1254f3c6c24
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:26:28Z
Merge branch 'NIFI-3603' of https://github.com/wangrenlei/nifi-1 into NIFI-3603
commit 216d4d84d67dba21ab76264c14ee1221c8c654dc
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:33:28Z
NIFI-3603:Add the *.properties file
commit 60492b13c10cbab667d3b3cc2e9aaacc2a2341a2
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:36:05Z
nothing
commit 5d1c68b7bde3c7601b3f4d411c14a00253bc0b05
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:38:36Z
NIFI-3603: Updated js directory to add *.js localized changes and add gloabalization directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1604: NIFI-3603：localization needed
Posted by qfdk <gi...@git.apache.org>.
Github user qfdk commented on the issue:
https://github.com/apache/nifi/pull/1604
@wangrenlei Thank you for your hard work :) @ijokarumawak you too :) This pr is very useful :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1604: NIFI-3603：localization needed
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1604
@wangrenlei The Travis result looks fine. Builds using default or US locale passed:
There're tests that fail with other Locales as reported by [NIFI-3466](https://issues.apache.org/jira/browse/NIFI-3466). So for this PR, I think it's time for further detailed code level review. I am not sure if I have enough bandwidth to review it this week but try when I have time.
Anyone interested in this contribution, please jump in reviewing process!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1604: NIFI-3603���localization needed
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1604
This PR is superseded by #1913.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1604: NIFI-3603：localization needed
Posted by wangrenlei <gi...@git.apache.org>.
Github user wangrenlei commented on the issue:
https://github.com/apache/nifi/pull/1604
@ijokarumawak @qfdk Thank you very much, we hope that you can review it as soon as possible so that we can better maintain it, and later need to Chinese localization of the module, we are willing to do the translation work. And We are from Weiresearch Info Tech.,Ltd, Keep in touch and thank again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1604: NIFI-3603���localization needed
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1604
@wangrenlei Probably closing this PR and let your colleague send another PR from his branch would do that, if he is going to manage this PR from now on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1604: NIFI-3603���localization needed
Posted by wangrenlei <gi...@git.apache.org>.
Github user wangrenlei commented on the issue:
https://github.com/apache/nifi/pull/1604
@ijokarumawak Now I need to hand over this part of the job to another colleague, how should I submit the PR I submitted to him?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1604: NIFI-3603：localization needed
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1604#discussion_r106852844
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/java/Messages_cn.properties ---
@@ -0,0 +1,785 @@
+#-------------------------------------------------
--- End diff --
@wangrenlei Travis CI reported [RAT check error](https://travis-ci.org/apache/nifi/jobs/212601713) as below:
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (default-cli) on project nifi-web-ui: Too many files with unapproved license: 5 See RAT report in: /home/travis/build/apache/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/rat.txt -> [Help 1]
```
I haven't checked out this PR yet, but suspect these RAT errors came from newly added properties files (or other files). Because those don't have appropriate license note in it. Please add Apache 2 License note at the head of each files. [nifi.properties](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties) can be a reference for doing that.
Then please make sure mvn build passes with `contrib-check` profile as written in the [Contributor Guide](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Providingcodeordocumentationcontributions):
```
# Test your changes
For code changes, ensure that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder. Please write or update unit tests to verify your changes.
Did your change introduce new dependencies? Are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? Did you update the LICENSE file?
For documentation related changes, ensure that format looks appropriate for the output in which it is rendered.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1604: NIFI-3603���localization needed
Posted by wangrenlei <gi...@git.apache.org>.
Github user wangrenlei closed the pull request at:
https://github.com/apache/nifi/pull/1604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1604: NIFI-3603：localization needed
Posted by wangrenlei <gi...@git.apache.org>.
Github user wangrenlei commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1604#discussion_r107082255
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/java/Messages_cn.properties ---
@@ -0,0 +1,785 @@
+#-------------------------------------------------
--- End diff --
@ijokarumawak I have modified some errors\uff0cbut now \uff0cthe master branch looks like it is not successful by building . And i did not modify anything about those error points .
Is that nifi own error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---