You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/08/19 10:36:54 UTC
[GitHub] flink pull request #2391: [FLINK-3580] [table] Implement FLOOR/CEIL for time...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2391
[FLINK-3580] [table] Implement FLOOR/CEIL for time points
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR implements FLOOR/CEIL functions for DATE, TIME, TIMESTAMP types.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-3580_FLOOR_CEIL
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2391
----
commit 5c77dfeed41568c1c524406eeb2332ddd48bdcf4
Author: twalthr <tw...@apache.org>
Date: 2016-08-19T10:18:49Z
[FLINK-3580] [table] Implement FLOOR/CEIL for time points
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2391: [FLINK-3580] [table] Implement FLOOR/CEIL for time...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2391#discussion_r76237586
--- Diff: docs/apis/table.md ---
@@ -1445,6 +1445,28 @@ TEMPORAL.extract(TIMEINTERVALUNIT)
</td>
</tr>
+ <tr>
+ <td>
+ {% highlight java %}
+TIMEPOINT.floor(TIMEINTERVALUNIT)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>Rounds down a time point to the given unit. E.g. <code>"12:44:31".toDate.floor(MINUTE)</code> leads to 12:44:00.</p>
+ </td>
+ </tr>
+
+ <tr>
+ <td>
+ {% highlight java %}
+TIMEPOINT.ceil(TIMEINTERVALUNIT)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>Rounds up a time point to the given unit. E.g. <code>"12:44:31".toTime.floor(MINUTE)</code> leads to 12:45:00.</p>
--- End diff --
"Rounds a time point up to the given unit." ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2391: [FLINK-3580] [table] Implement FLOOR/CEIL for time...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2391#discussion_r76237569
--- Diff: docs/apis/table.md ---
@@ -1445,6 +1445,28 @@ TEMPORAL.extract(TIMEINTERVALUNIT)
</td>
</tr>
+ <tr>
+ <td>
+ {% highlight java %}
+TIMEPOINT.floor(TIMEINTERVALUNIT)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>Rounds down a time point to the given unit. E.g. <code>"12:44:31".toDate.floor(MINUTE)</code> leads to 12:44:00.</p>
--- End diff --
"Rounds a time point down to the given unit." ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2391: [FLINK-3580] [table] Implement FLOOR/CEIL for time points
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2391
If there are no objections, I would merge this later today.
@fhueske ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2391: [FLINK-3580] [table] Implement FLOOR/CEIL for time points
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2391
Thanks @fhueske. I will address your comments and merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2391: [FLINK-3580] [table] Implement FLOOR/CEIL for time...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2391: [FLINK-3580] [table] Implement FLOOR/CEIL for time points
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2391
Looks good! Thanks, @twalthr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---