You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SpriCoder (via GitHub)" <gi...@apache.org> on 2024/01/27 17:00:51 UTC
[PR] Revert "Fixed issue where ConfigNode might recover incorrectly under SimpleConsensus" [iotdb]
SpriCoder opened a new pull request, #11987:
URL: https://github.com/apache/iotdb/pull/11987
Reverts apache/iotdb#11969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Fixed issue where ConfigNode might recover incorrectly under SimpleConsensus" [iotdb]
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #11987:
URL: https://github.com/apache/iotdb/pull/11987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Fixed issue where ConfigNode might recover incorrectly under SimpleConsensus" [iotdb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11987:
URL: https://github.com/apache/iotdb/pull/11987#issuecomment-1913273955
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11987?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`a544517`)](https://app.codecov.io/gh/apache/iotdb/commit/a5445177d5d53cda7ad6a5104c2e41e2b4de5c3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.22% compared to head [(`3cde922`)](https://app.codecov.io/gh/apache/iotdb/pull/11987?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.22%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #11987 +/- ##
=========================================
Coverage 49.22% 49.22%
+ Complexity 26078 26074 -4
=========================================
Files 2931 2931
Lines 183563 183553 -10
Branches 22014 22014
=========================================
+ Hits 90353 90356 +3
+ Misses 93210 93197 -13
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11987?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Fixed issue where ConfigNode might recover incorrectly under SimpleConsensus" [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11987:
URL: https://github.com/apache/iotdb/pull/11987#issuecomment-1913265298
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11987) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11987&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11987&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11987)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org