You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/31 08:38:06 UTC

[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request #1657: fix bug #1544 : workflow import bug

Yeleights opened a new pull request #1657: fix bug #1544 : workflow import bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1657
 
 
   ## What is the purpose of the pull request
   *#1544 fix bug: workflow import *
   
   ## Brief change log
     - *Edit api.service.ProcessDefinitionService*
     - *add currentProject param when workflow import*
     - *create sub process when cross-project workflow import*
     - *add project permission check when import workflow*
   
   ## Verify this pull request
     - *Manually verified the change by testing locally.*
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1657: fix bug #1544 : workflow import bug

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1657: fix bug #1544 : workflow import bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1657#issuecomment-569889689
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`dev@19044a2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0.91%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657?src=pr&el=tree)
   
   ```diff
   @@          Coverage Diff          @@
   ##             dev   #1657   +/-   ##
   =====================================
     Coverage       ?   13.3%           
   =====================================
     Files          ?     284           
     Lines          ?   14025           
     Branches       ?    2280           
   =====================================
     Hits           ?    1866           
     Misses         ?   11952           
     Partials       ?     207
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...inscheduler/common/job/db/SQLServerDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9TUUxTZXJ2ZXJEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | |
   | [...phinscheduler/common/job/db/PostgreDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9Qb3N0Z3JlRGF0YVNvdXJjZS5qYXZh) | `0% <ø> (ø)` | |
   | [...olphinscheduler/common/job/db/SparkDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9TcGFya0RhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | |
   | [...dolphinscheduler/common/utils/EncryptionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VuY3J5cHRpb25VdGlscy5qYXZh) | `100% <ø> (ø)` | |
   | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | |
   | [...olphinscheduler/common/job/db/MySQLDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9NeVNRTERhdGFTb3VyY2UuamF2YQ==) | `0% <ø> (ø)` | |
   | [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `0% <ø> (ø)` | |
   | [...lphinscheduler/common/job/db/OracleDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2pvYi9kYi9PcmFjbGVEYXRhU291cmNlLmphdmE=) | `0% <ø> (ø)` | |
   | [...apache/dolphinscheduler/common/model/TaskNode.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL21vZGVsL1Rhc2tOb2RlLmphdmE=) | `0% <ø> (ø)` | |
   | [...che/dolphinscheduler/common/utils/CommonUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0NvbW1vblV0aWxzLmphdmE=) | `0% <ø> (ø)` | |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657?src=pr&el=footer). Last update [19044a2...4a555bf](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1657?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Yeleights closed pull request #1657: fix bug #1544 : workflow import bug

Posted by GitBox <gi...@apache.org>.
Yeleights closed pull request #1657: fix bug #1544 : workflow import bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1657
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #1657: fix bug #1544 : workflow import bug

Posted by GitBox <gi...@apache.org>.
Yeleights commented on issue #1657: fix bug #1544 : workflow import bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1657#issuecomment-570109952
 
 
   i neet add UT

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services