[PATCH] Many, many nits in modules

[John Bley <jb...@acpub.duke.edu>]

I took a look at the static initializers in the various modules subdirs and 
found loads of sparse ones.  Like, a 24KB patch worth.

99% of these are the list-stopper { NULL }s for handler_recs and 
command_recs, but there was one outlier in mod_so.c, where somebody had 
forgotten that the fixer_upper function pointer existed.  If this patch 
isn't accepted I'll resend a patch for that outlier, since it feels funny.

Anyway, the patch (in diff -u against 1.3.4 clean) is at 
  http://www.duke.edu/~jbb6/apache-nits-patch.txt

I tried to follow { Foo } or {Foo} style as much as I could.

-- 
John Bley - jbb6@acpub.duke.edu
Duke '99 - English/Computer Science
  Since English is a mess, it maps well onto the problem space,
  which is also a mess, which we call reality.     - Larry Wall

Re: [PATCH] Many, many nits in modules

[Greg Stein <gs...@lyra.org>]

John Bley wrote:
> 
> I took a look at the static initializers in the various modules subdirs and
> found loads of sparse ones.  Like, a 24KB patch worth.
> 
> 99% of these are the list-stopper { NULL }s for handler_recs and
> command_recs, but there was one outlier in mod_so.c, where somebody had
> forgotten that the fixer_upper function pointer existed.  If this patch
> isn't accepted I'll resend a patch for that outlier, since it feels funny.

Why go thru all that, when C says that NULLs are automatically filled
in? If a new member is added to a structure, you'll just need to go and
retrofit all those initializers again.

Cheers,
-g

--
Greg Stein, http://www.lyra.org/