You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:57:03 UTC
[GitHub] [flink] austince opened a new pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
austince opened a new pull request #12001:
URL: https://github.com/apache/flink/pull/12001
## What is the purpose of the change
This pull request makes the queue declaration in the RabbitMQ Source and Sink consistent. Previously, the Source asserted a durable queue while the Sink asserted a transient queue. This made using the same queue for input and output impossible (as described in the ticket FLINK-17204). The rationale for setting queues to durable by default is taken from the RabbitMQ UI defaults, shown here:
The classes can still be overridden if end users want different default semantics.
## Brief change log
- The `RMQSink` asserts durable queues
## Verifying this change
This change added tests and can be verified as follows:
*(example:)*
- Added a unit test `RMQSourceTest.testOpenCallDeclaresQueueInStandardMode()`, similar to the existing tests in `RMQSinkTest`, which confirm that the queue is asserted with consistent parametersTaskManagers during the execution, verifying that recovery happens correctly.*
- Updated the existing unit tests in `RMQSinkTest` to assert that durable queues are created
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
I couldn't find any mention of the current configuration in the JavaDocs [[RMQSink]](https://ci.apache.org/projects/flink/flink-docs-release-1.10/api/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.html) [[RMQSource]](https://ci.apache.org/projects/flink/flink-docs-release-1.10/api/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.html), though I'm happy to add docs around this if that would be helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r421574947
##########
File path: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
##########
@@ -86,13 +86,23 @@
private volatile Exception exception;
- @Before
- public void beforeTest() throws Exception {
-
+ /**
+ * Get a mock context for initializing the source's state.
+ *
+ * @return a mocked context that can be used in {@link org.apache.flink.streaming.api.checkpoint.CheckpointedFunction#initializeState}
Review comment:
Makes sense to me, will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r421574947
##########
File path: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
##########
@@ -86,13 +86,23 @@
private volatile Exception exception;
- @Before
- public void beforeTest() throws Exception {
-
+ /**
+ * Get a mock context for initializing the source's state.
+ *
+ * @return a mocked context that can be used in {@link org.apache.flink.streaming.api.checkpoint.CheckpointedFunction#initializeState}
Review comment:
Makes sense to me, will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd20d1744653fe796408d892b6c9a7b4560b35ae Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r422275241
##########
File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/Util.java
##########
@@ -0,0 +1,17 @@
+package org.apache.flink.streaming.connectors.rabbitmq;
Review comment:
I'll look for that one next time :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r422263699
##########
File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/Util.java
##########
@@ -0,0 +1,17 @@
+package org.apache.flink.streaming.connectors.rabbitmq;
Review comment:
CI is failing because this file is missing a license header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd20d1744653fe796408d892b6c9a7b4560b35ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r421575576
##########
File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
##########
@@ -121,7 +121,7 @@ public RMQSink(RMQConnectionConfig rmqConnectionConfig, SerializationSchema<IN>
*/
protected void setupQueue() throws IOException {
if (queueName != null) {
- channel.queueDeclare(queueName, false, false, false, null);
+ channel.queueDeclare(queueName, true, false, false, null);
Review comment:
I agree, thanks for the suggestion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd20d1744653fe796408d892b6c9a7b4560b35ae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624245044
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fa3c17975b5adea19ef101966640296cffadd773 (Tue May 05 19:00:32 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r422272895
##########
File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/Util.java
##########
@@ -0,0 +1,17 @@
+package org.apache.flink.streaming.connectors.rabbitmq;
Review comment:
Years of experience reading maven output :)
This is the line
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project flink-parent: Too many files with unapproved license: 1 See RAT report in: /__w/2/s/target/rat.txt -> [Help 1]
```
It doesn't tell us the file, but it's obvious when you look at the PR changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-625360927
Rebased from master and addressed comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
}, {
"hash" : "97b238c935e87f6c6894d227433990c63f89037e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=768",
"triggerID" : "97b238c935e87f6c6894d227433990c63f89037e",
"triggerType" : "PUSH"
}, {
"hash" : "4a53a2bcbfd35f3c8c9542a40c26251d364df7c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=841",
"triggerID" : "4a53a2bcbfd35f3c8c9542a40c26251d364df7c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97b238c935e87f6c6894d227433990c63f89037e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=768)
* 4a53a2bcbfd35f3c8c9542a40c26251d364df7c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=841)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r421361436
##########
File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
##########
@@ -121,7 +121,7 @@ public RMQSink(RMQConnectionConfig rmqConnectionConfig, SerializationSchema<IN>
*/
protected void setupQueue() throws IOException {
if (queueName != null) {
- channel.queueDeclare(queueName, false, false, false, null);
+ channel.queueDeclare(queueName, true, false, false, null);
Review comment:
This would just be icing on the cake but you could factor out these defaults into a package-private Util, with a method, something like `declareQueueDefaults(Channel channel, String queueName)`. Totally up to you, though. This is already an improvement.
If you do it, just do the refactor in a commit on top.
##########
File path: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
##########
@@ -86,13 +86,23 @@
private volatile Exception exception;
- @Before
- public void beforeTest() throws Exception {
-
+ /**
+ * Get a mock context for initializing the source's state.
+ *
+ * @return a mocked context that can be used in {@link org.apache.flink.streaming.api.checkpoint.CheckpointedFunction#initializeState}
Review comment:
Maybe that's just my style but I often prefer Javadoc without a `@return` clause if it's a duplicate of the main text. Here the main text can just be `Gets a mock context for initializing the source's state via {@link org.apache.flink.streaming.api.checkpoint.CheckpointedFunction#initializeState}.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r421574947
##########
File path: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
##########
@@ -86,13 +86,23 @@
private volatile Exception exception;
- @Before
- public void beforeTest() throws Exception {
-
+ /**
+ * Get a mock context for initializing the source's state.
+ *
+ * @return a mocked context that can be used in {@link org.apache.flink.streaming.api.checkpoint.CheckpointedFunction#initializeState}
Review comment:
Makes sense to me, will update. Should I remove the `@throws` clause as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
}, {
"hash" : "97b238c935e87f6c6894d227433990c63f89037e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "97b238c935e87f6c6894d227433990c63f89037e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd20d1744653fe796408d892b6c9a7b4560b35ae Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653)
* 97b238c935e87f6c6894d227433990c63f89037e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on a change in pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on a change in pull request #12001:
URL: https://github.com/apache/flink/pull/12001#discussion_r422268851
##########
File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/Util.java
##########
@@ -0,0 +1,17 @@
+package org.apache.flink.streaming.connectors.rabbitmq;
Review comment:
Ah, thank you! Did you find this in the CI logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] austince commented on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
austince commented on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-625450514
Ran all tests locally and passed, unsure why CI is failing but it seems unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
}, {
"hash" : "97b238c935e87f6c6894d227433990c63f89037e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=768",
"triggerID" : "97b238c935e87f6c6894d227433990c63f89037e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97b238c935e87f6c6894d227433990c63f89037e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=768)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
}, {
"hash" : "97b238c935e87f6c6894d227433990c63f89037e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=768",
"triggerID" : "97b238c935e87f6c6894d227433990c63f89037e",
"triggerType" : "PUSH"
}, {
"hash" : "4a53a2bcbfd35f3c8c9542a40c26251d364df7c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=841",
"triggerID" : "4a53a2bcbfd35f3c8c9542a40c26251d364df7c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a53a2bcbfd35f3c8c9542a40c26251d364df7c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=841)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12001: [FLINK-17204][connectors/rabbitmq] Make RMQ queue declaration consistent between source and sink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12001:
URL: https://github.com/apache/flink/pull/12001#issuecomment-624253499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=653",
"triggerID" : "cd20d1744653fe796408d892b6c9a7b4560b35ae",
"triggerType" : "PUSH"
}, {
"hash" : "97b238c935e87f6c6894d227433990c63f89037e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=768",
"triggerID" : "97b238c935e87f6c6894d227433990c63f89037e",
"triggerType" : "PUSH"
}, {
"hash" : "4a53a2bcbfd35f3c8c9542a40c26251d364df7c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a53a2bcbfd35f3c8c9542a40c26251d364df7c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 97b238c935e87f6c6894d227433990c63f89037e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=768)
* 4a53a2bcbfd35f3c8c9542a40c26251d364df7c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org