You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/15 17:29:35 UTC
[GitHub] [beam] damccorm opened a new pull request, #21896: Use Go 1.18 for go-licenses
damccorm opened a new pull request, #21896:
URL: https://github.com/apache/beam/pull/21896
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156819383
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156745104
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #21896:
URL: https://github.com/apache/beam/pull/21896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156817797
Run PythonDocker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156750875
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156817940
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156745106
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156834437
Not everything is finished running, but the ones that are that run this target have already build and executed the change. Merging to unblock builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156745107
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156906521
ah thanks for fixing this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156822303
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #21896:
URL: https://github.com/apache/beam/pull/21896#discussion_r898410392
##########
release/go-licenses/Dockerfile:
##########
@@ -16,8 +16,11 @@
# limitations under the License.
###############################################################################
-FROM golang:1.16-bullseye
-RUN go get github.com/google/go-licenses@v1.0.0
+FROM golang:1.18-bullseye
+
+WORKDIR /usr/src/app
+COPY go.mod ./
+RUN go install github.com/google/go-licenses@v1.0.0
Review Comment:
I agree that latest is probably best, I just wanted to keep this change minimal since this was blocking others. #21901 bumps this to latest.
If we run into issues with that we can also pin the version at a later date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156745103
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156826177
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156745108
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #21896:
URL: https://github.com/apache/beam/pull/21896#discussion_r898325924
##########
release/go-licenses/Dockerfile:
##########
@@ -16,8 +16,11 @@
# limitations under the License.
###############################################################################
-FROM golang:1.16-bullseye
-RUN go get github.com/google/go-licenses@v1.0.0
+FROM golang:1.18-bullseye
+
+WORKDIR /usr/src/app
+COPY go.mod ./
+RUN go install github.com/google/go-licenses@v1.0.0
Review Comment:
We should file an issue to bump the version to the [latest version (1.2.1)](https://pkg.go.dev/github.com/google/go-licenses@v1.2.1). Since we're trying to unblock things, we're probably fine not doing it in this PR.
I'd consider just making the target @latest instead though, it's unlikely to cause breaking changes, and allow additional license detection over time.
https://github.com/google/go-licenses/tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156826298
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #21896: Use Go 1.18 for go-licenses
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #21896:
URL: https://github.com/apache/beam/pull/21896#issuecomment-1156745409
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org