You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Pier Fumagalli <pi...@betaversion.org> on 2002/04/03 16:33:01 UTC
[PATCH] hard-coded paths leftovers...
This is for mod_cgid.c
Index: modules/generators/mod_cgid.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/generators/mod_cgid.c,v
retrieving revision 1.125
diff -U3 -r1.125 mod_cgid.c
--- modules/generators/mod_cgid.c 30 Mar 2002 23:55:16 -0000 1.125
+++ modules/generators/mod_cgid.c 3 Apr 2002 14:31:29 -0000
@@ -149,7 +149,12 @@
#define DEFAULT_LOGBYTES 10385760
#define DEFAULT_BUFBYTES 1024
-#define DEFAULT_SOCKET "logs/cgisock"
+
+/* This is for windows (w/o autoconf we don't generate ap_config_layout.hi)
*/
+#ifndef DEFAULT_REL_RUNTIMEDIR
+#define DEFAULT_REL_RUNTIMEDIR "logs"
+#endif
+#define DEFAULT_SOCKET DEFAULT_REL_RUNTIMEDIR "/cgisock"
#define CGI_REQ 1
#define SSI_REQ 2
Re: [PATCH] hard-coded paths leftovers...
Posted by Pier Fumagalli <pi...@betaversion.org>.
Ryan Bloom <rb...@covalent.net> wrote:
>
>> This is for mod_cgid.c
>>
>> Index: modules/generators/mod_cgid.c
>> ===================================================================
>> RCS file: /home/cvspublic/httpd-2.0/modules/generators/mod_cgid.c,v
>> retrieving revision 1.125
>> diff -U3 -r1.125 mod_cgid.c
>> --- modules/generators/mod_cgid.c 30 Mar 2002 23:55:16 -0000 1.125
>> +++ modules/generators/mod_cgid.c 3 Apr 2002 14:31:29 -0000
>> @@ -149,7 +149,12 @@
>>
>> #define DEFAULT_LOGBYTES 10385760
>> #define DEFAULT_BUFBYTES 1024
>> -#define DEFAULT_SOCKET "logs/cgisock"
>> +
>> +/* This is for windows (w/o autoconf we don't generate
>> ap_config_layout.hi)
>> */
>
> Mod_cgid doesn't work on Windows, and I'm not really sure that it makes
> sense. Windows programs don't seem to have the problem that Unix does
> forking a threaded process, probably because every fork on Windows is a
> fork/exec, so they don't need to create the threads just to kill them
> off.
I'm happily free of Windows on this side of the planet... I have no
whatsoever clue on how AP2 is supposed to work there, so, I just added it to
be on the safe side, because I noticed that in ap_config.h ap_config_auto.h
(and therefore ap_config_layout.h) are included only if !defined WIN &
!defined NETWARE...
That's for the windows weirdoes :) to figure out :) :) :)
Pier
RE: [PATCH] hard-coded paths leftovers...
Posted by Ryan Bloom <rb...@covalent.net>.
> This is for mod_cgid.c
>
> Index: modules/generators/mod_cgid.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/modules/generators/mod_cgid.c,v
> retrieving revision 1.125
> diff -U3 -r1.125 mod_cgid.c
> --- modules/generators/mod_cgid.c 30 Mar 2002 23:55:16 -0000 1.125
> +++ modules/generators/mod_cgid.c 3 Apr 2002 14:31:29 -0000
> @@ -149,7 +149,12 @@
>
> #define DEFAULT_LOGBYTES 10385760
> #define DEFAULT_BUFBYTES 1024
> -#define DEFAULT_SOCKET "logs/cgisock"
> +
> +/* This is for windows (w/o autoconf we don't generate
> ap_config_layout.hi)
> */
Mod_cgid doesn't work on Windows, and I'm not really sure that it makes
sense. Windows programs don't seem to have the problem that Unix does
forking a threaded process, probably because every fork on Windows is a
fork/exec, so they don't need to create the threads just to kill them
off.
> +#ifndef DEFAULT_REL_RUNTIMEDIR
> +#define DEFAULT_REL_RUNTIMEDIR "logs"
> +#endif
> +#define DEFAULT_SOCKET DEFAULT_REL_RUNTIMEDIR "/cgisock"
>
> #define CGI_REQ 1
> #define SSI_REQ 2
>
Ryan