You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/05/15 09:09:48 UTC

[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1755: nshlib: Add support for disabling echoback

xiaoxiang781216 commented on code in PR #1755:
URL: https://github.com/apache/nuttx-apps/pull/1755#discussion_r1193554530


##########
nshlib/nsh_session.c:
##########
@@ -169,6 +170,21 @@ int nsh_session(FAR struct console_stdio_s *pstate,
         }
     }
 
+#if CONFIG_NSH_DISABLE_ECHOBACK

Review Comment:
   should we move the change before line 104?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org