[GitHub] Antonio-Maranhao commented on a change in pull request #1070: Replication redux

[GitBox <gi...@apache.org>]

Antonio-Maranhao commented on a change in pull request #1070: Replication redux
URL: https://github.com/apache/couchdb-fauxton/pull/1070#discussion_r179256644
 
 

 ##########
 File path: app/addons/replication/route.js
 ##########
 @@ -40,32 +40,34 @@ const ReplicationRouteObject = FauxtonAPI.RouteObject.extend({
     ];
   },
 
-  defaultView: function (databaseName) {
+  createView: function (databaseName) {
     const localSource = databaseName || '';
-    Actions.changeTabSection('new replication');
-    Actions.clearReplicationForm();
+    // Actions.clearReplicationForm();
 
     return <ReplicationController
-      localSource={localSource}
+      routeLocalSource={localSource}
+      section={'new replication'}
     />;
   },
 
-  fromId: function (replicationId) {
-    Actions.clearReplicationForm();
-    Actions.changeTabSection('new replication');
+  createViewFromId: function (replicationId) {
     return <ReplicationController
       replicationId={replicationId}
+      section={'new replication'}
     />;
   },
 
   activityView: function () {
-    Actions.changeTabSection('activity');
-    return <ReplicationController/>;
+    return <ReplicationController
+      section={"activity"}
+    />;
   },
 
   replicateView: function () {
     Actions.changeTabSection('_replicate');
 
 Review comment:
   Remove this line since the action doesn't exist anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services