You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/29 09:17:10 UTC
[GitHub] [arrow] dragosmg opened a new pull request, #13029: ARROW-16255: [R] Reorganise the datetime bindings
dragosmg opened a new pull request, #13029:
URL: https://github.com/apache/arrow/pull/13029
The purpose of this PR is to reorganise the datetime bindings.
Why?
* some are in files where one wouldn't think to look (e.g. in `R/dplyr-funcs-type.R`)
* the are a bunch of somewhat scattered helper functions
* some of the `register_bindings_...()` functions are too complex and trigger the cyclocomp lint
What?
* create a separate file for the datetime helpers, called `R/dplyr-datetime-helpers.R`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13029: ARROW-16255: [R] Reorganise the datetime bindings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13029:
URL: https://github.com/apache/arrow/pull/13029#issuecomment-1113114226
https://issues.apache.org/jira/browse/ARROW-16255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed pull request #13029: ARROW-16255: [R] Reorganise the datetime bindings
Posted by GitBox <gi...@apache.org>.
thisisnic closed pull request #13029: ARROW-16255: [R] Reorganise the datetime bindings
URL: https://github.com/apache/arrow/pull/13029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13029: ARROW-16255: [R] Reorganise the datetime bindings
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13029:
URL: https://github.com/apache/arrow/pull/13029#issuecomment-1120358738
Benchmark runs are scheduled for baseline = 7f6b074b84b1ca519b7c5fc7da318e8d47d44278 and contender = 893faa741f34ee450070503566dafb7291e24d9f. 893faa741f34ee450070503566dafb7291e24d9f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e2592c5d9a604071bae034a1556f635e...210626ba1faf4bf5af912596f110a341/)
[Finished :arrow_down:0.43% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/aa84145048fb44108095b94dd02ae5f9...39d0fc6c235d4730bb846486d32219f1/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b529fb63aa9c499dba9d6892c752181d...a7cc3bcf62cf4f419de94bd15841ec28/)
[Finished :arrow_down:0.32% :arrow_up:0.08%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d48fab4fd8dc48a3a835bbd7e24fa8a0...c941a5a3212f4d22b62ddbdeeff60b41/)
Buildkite builds:
[Finished] [`893faa74` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/696)
[Finished] [`893faa74` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/693)
[Finished] [`893faa74` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/682)
[Finished] [`893faa74` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/698)
[Finished] [`7f6b074b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/695)
[Finished] [`7f6b074b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/692)
[Finished] [`7f6b074b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/681)
[Finished] [`7f6b074b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/697)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13029: ARROW-16255: [R] Reorganise the datetime bindings
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13029:
URL: https://github.com/apache/arrow/pull/13029#issuecomment-1120358787
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/aa84145048fb44108095b94dd02ae5f9...39d0fc6c235d4730bb846486d32219f1/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org