[GitHub] [helix] qqu0127 commented on a diff in pull request #2351: Add code and code translator

["qqu0127 (via GitHub)" <gi...@apache.org>]

qqu0127 commented on code in PR #2351:
URL: https://github.com/apache/helix/pull/2351#discussion_r1094714056


##########
meta-client/src/main/java/org/apache/helix/metaclient/exception/MetaClientException.java:
##########
@@ -36,4 +36,115 @@ public MetaClientException(Throwable cause) {
     super(cause);
   }
 
+  public enum ReturnCode {
+    /** Connection to the server has been lost. */
+    CONNECTION_LOSS(-105, "Connection to the server has been lost.") {
+    },
+
+    /** Operation is unimplemented. */
+    UNIMPLEMENTED(-104, "Operation is unimplemented.") {
+    },

Review Comment:
   For those enum that don't override, I don't think the { } is needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org