[jira] [Commented] (FLINK-9328) RocksDBStateBackend might use PlaceholderStreamStateHandle to restor due to StateBackendTestBase class not register snapshots in some UTs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470165#comment-16470165 ] 

ASF GitHub Bot commented on FLINK-9328:
---------------------------------------

GitHub user Myasuka opened a pull request:

    https://github.com/apache/flink/pull/5984

    [FLINK-9328][state] Fix RocksDBStateBackend restore problem due to StateBackendTestBase not registering snapshots

    
    ## What is the purpose of the change
    
    Currently, StateBackendTestBase class does not register snapshots to SharedStateRegistry in testValueState, testListState, testReducingState, testFoldingState and testMapState UTs, which may cause RocksDBStateBackend to restore from PlaceholderStreamStateHandle during the 2nd restore procedure if one specific sst file both existed in the 1st snapshot and the 2nd snapshot handle.
    
    
    ## Brief change log
    
    Add sharedStateRegistry and register each snapshot to it.
    
    ## Verifying this change
    
    This change fix UT problem.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Myasuka/flink fix-StateBackendTestBase-FLINK-9328

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5984.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5984
    
----
commit a2aed70803a99124d63156a5e5146f6fff1ee83d
Author: Myasuka <my...@...>
Date:   2018-05-10T09:48:53Z

    [FLINK-9328][state] Fix RocksDBStateBackend restore problem due to StateBackendTestBase not registering snapshots

----


> RocksDBStateBackend might use PlaceholderStreamStateHandle to restor due to StateBackendTestBase class not register snapshots in some UTs
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-9328
>                 URL: https://issues.apache.org/jira/browse/FLINK-9328
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.4.2
>            Reporter: Yun Tang
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> Currently, StateBackendTestBase class does not register snapshots to SharedStateRegistry in testValueState, testListState, testReducingState, testFoldingState and testMapState UTs, which may cause RocksDBStateBackend to restore from PlaceholderStreamStateHandle during the 2nd restore procedure if one specific sst file both existed in the 1st snapshot and the 2nd snapshot handle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)