[GitHub] [incubator-doris] imay commented on a change in pull request #1568: initial implementation of BetaRowset

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1568: initial implementation of BetaRowset
URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310387276
 
 

 ##########
 File path: gensrc/proto/olap_file.proto
 ##########
 @@ -76,25 +76,26 @@ message RowsetMetaPB {
     required int64 rowset_id = 1;
     optional int64 partition_id = 2;
     optional int64 tablet_id = 3;
-    optional int64 txn_id = 4;
+    optional int64 txn_id = 4;              // only for pending rowset
     optional int32 tablet_schema_hash = 5;  // tablet id and schema hash could find tablet
     optional RowsetTypePB rowset_type = 6;  // alpha
     optional RowsetStatePB rowset_state = 7;
-    optional int64 start_version = 8;   // PDelta.start_version
-    optional int64 end_version = 9; // PDelta.end_version
-    optional int64 version_hash = 10; // PDelta.version_hash
-    optional int64 num_rows = 11;   // calculated from segment group
-    optional int64 total_disk_size = 12;   // calculated by index + data
-    optional int64 data_disk_size = 13;   // calculated sum(segmentgroup.data_size)
-    optional int64 index_disk_size = 14;   // calculated sum(segmentgroup.index_size)
+    optional int64 start_version = 8;       // PDelta.start_version, only for visible rowset
 
 Review comment:
   Putting comment above is better 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org