[GitHub] [geode] jinmeiliao commented on pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

[GitBox <gi...@apache.org>]

jinmeiliao commented on pull request #5285:
URL: https://github.com/apache/geode/pull/5285#issuecomment-649039263


   > I have some questions about `SingleGfshCommand`, which is extended by commands that will update cluster config. Now in this pull request, quite a few classes used to be subclasses of `SingleGfshCommand` now become the subclasses of `GfshCommand`. Does it mean that these classes don't update cluster config any more?
   
   They don't update cluster config at all. They don't need to extends SingleGfshCommand in the first place and they didn't even implement the `updateGroupConfig` method at all.
   
   > 
   > By default, the subclasses of `GfshCommand` returns `false` for `affectsClusterConfiguration`. But some class, e.g. `AlterRuntimeConfigCommand` that extends `GfshCommand` returns `true` for `affectsClusterConfiguration`. Why is that?
   
   Because AlterRuntimConfigComand does affect cluster configuration. It updates the properties part of the cluster configuration.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org