You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "maobaolong (via GitHub)" <gi...@apache.org> on 2024/08/02 03:59:42 UTC
[PR] Remove reg time of ServerNode as there is start time instead [incubator-uniffle]
maobaolong opened a new pull request, #2005:
URL: https://github.com/apache/incubator-uniffle/pull/2005
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
<img width="2354" alt="image" src="https://github.com/user-attachments/assets/0e98286f-950a-45df-8f77-b8449c907329">
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] improve(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2005:
URL: https://github.com/apache/incubator-uniffle/pull/2005#issuecomment-2264518271
## Test Results
2 747 files ±0 2 747 suites ±0 5h 39m 13s :stopwatch: +57s
979 tests ±0 977 :white_check_mark: - 1 1 :zzz: ±0 1 :x: +1
12 294 runs ±0 12 278 :white_check_mark: - 1 15 :zzz: ±0 1 :x: +1
For more details on these failures, see [this check](https://github.com/apache/incubator-uniffle/runs/28248791188).
Results for commit 4259c835. ± Comparison against base commit c3e1f609.
[test-results]:data:application/gzip;base64,H4sIAF1frGYC/1XPyQ6DIBSF4VcxrLtAhl7pyzSAkJA6NAwr03fvxaily/+DnMBGfJhcIo+OgYBbR1IJue2xRJ3DulShXHIkPM/1hgJ11jMVa3eCH73CG6m/wOsw/YGLcY0oFCWWpW72jClx5DmKBsNlx6o8oVndux216zyHjEEEk8oO+P67cfizkYM0moORjnvv2aj0AFRwST5fuVdK9xIBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] improvement(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2005:
URL: https://github.com/apache/incubator-uniffle/pull/2005#issuecomment-2327702036
> Registration time is still useful. If the shuffle server heartbeat time out, the registration time will be change.
<img width="496" alt="image" src="https://github.com/user-attachments/assets/b13ec346-103e-4c88-ac7f-a6c4312cdada">
You are right 👍, we found a server lost and coming back today from registrationTime, maybe OOM pause or some other reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] improve(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #2005: [MINOR] improve(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead
URL: https://github.com/apache/incubator-uniffle/pull/2005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] improve(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #2005:
URL: https://github.com/apache/incubator-uniffle/pull/2005#issuecomment-2264536495
@yl09099 Would you please take a look at this PR? BTW, it is so convenient to test dashboard without your invention of `mock js`. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] improvement(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead [incubator-uniffle]
Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #2005:
URL: https://github.com/apache/incubator-uniffle/pull/2005#issuecomment-2264707282
Registration time is still useful. If the shuffle server heartbeat time out, the registration time will be change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] improvement(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong closed pull request #2005: [MINOR] improvement(dashboard/coordinator): Remove reg time of ServerNode as there is start time instead
URL: https://github.com/apache/incubator-uniffle/pull/2005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org