[GitHub] [carbondata] nihal0107 commented on a change in pull request #4116: [CARBONDATA-4175] [CARBONDATA-4162] Leverage Secondary Index till segment level.

[GitBox <gi...@apache.org>]

nihal0107 commented on a change in pull request #4116:
URL: https://github.com/apache/carbondata/pull/4116#discussion_r629249133



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/index/secondary/SecondaryIndexModel.java
##########
@@ -99,5 +101,13 @@ public void setFetched(boolean fetched) {
     public Map<String, Set<String>> getSegmentToPosReferences() {
       return segmentToPosReferences;
     }
+
+    public void setValidSISegments(Set<String> validSISegments) {

Review comment:
       This segment list is nothing but the list of segments pruned by default index. Added validation to check if segment list present in SI and then used here.

##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/joins/BroadCastSIFilterPushJoin.scala
##########
@@ -135,6 +140,8 @@ object BroadCastSIFilterPushJoin {
 
   val logger: Logger = LogServiceFactory.getLogService(this.getClass.getName)
 
+  var missingSISegments: util.Set[String] = new util.HashSet[String]()

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org