You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/18 16:32:06 UTC

[GitHub] [thrift] ctubbsii commented on pull request #2553: THRIFT-5544: add java code gen param to support including field annotation as metadata

ctubbsii commented on PR #2553:
URL: https://github.com/apache/thrift/pull/2553#issuecomment-1101547357

   > > I think this could use a larger explanation. From these changes, including the added help documentation in the generator options, it's not clear what 'annotation metadata' is. What are common examples of annotation metadata, and how would these be used? The JIRA doesn't have any details in it, either: https://issues.apache.org/jira/browse/THRIFT-5544
   > 
   > @ctubbsii thanks for the comment. detailed explanation added to jira ticket and inline
   
   Thanks for the additional information. However, I'm still confused. Is this intended to serialize information about Java annotations `@Override`, `@Deprecated`, `@Nullable`, etc.? Are these annotations in the Java code that is generated from an `*.thrift` IDL file? Is the annotation defined in the `*.thrift` file or expected to be manually added after code generation?
   
   I'm just not clear on the end-to-end use of this. Do you have a simple example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org