You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/05/18 11:34:34 UTC

[GitHub] [incubator-doris] HappenLee opened a new pull request #3626: Update Compiling environment of BE to Support C++14/17

HappenLee opened a new pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626


   RT
   
   
   issue #3563 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-641071130


   I thought we had discussed it. .
   If this PR is incorporated, the current docker image needs to be upgraded, otherwise the new code cannot be compiled. If you think there is no problem, I have no opinion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] gengjun-git edited a comment on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
gengjun-git edited a comment on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-670811158


   @HappenLee hello, nice to see your contribute, but when I built docker image using your Dockerfile, error occurs as follows, Have you encountered this problem before? Thank you.
   
   ============log===================
   
   Finished patching s2geometry-0.9.0
   cmake version 3.12.3
   
   CMake suite maintained and supported by Kitware (kitware.com/cmake).
   cmake is found
   byacc - 1.9 20130304
   byacc is found
   flex 2.6.0
   flex is found
   automake (GNU automake) 1.15.1
   Copyright (C) 2017 Free Software Foundation, Inc.
   License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html>
   This is free software: you are free to change and redistribute it.
   There is NO WARRANTY, to the extent permitted by law.
   
   Written by Tom Tromey <tr...@redhat.com>
          and Alexandre Duret-Lutz <ad...@gnu.org>.
   automake is found
   libtoolize (GNU libtool) 2.4.2
   Written by Gary V. Vaughan <ga...@gnu.org>, 2003
   
   Copyright (C) 2011 Free Software Foundation, Inc.
   This is free software; see the source for copying conditions.  There is NO
   warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
   libtool is found
   ===== begin build libevent-master
   autoreconf: Entering directory `.'
   autoreconf: configure.ac: not using Gettext
   autoreconf: running: aclocal --force -I m4
   autoreconf: configure.ac: tracing
   autoreconf: configure.ac: not using Libtool
   autoreconf: running: /usr/bin/autoconf --force
   **configure.ac:129: error: possibly undefined macro: AC_PROG_LIBTOOL
         If this token and others are legitimate, please use m4_pattern_allow.
         See the Autoconf documentation.
   autoreconf: /usr/bin/autoconf failed with exit status: 1
   The command '/bin/sh -c cd ${DEFAULT_DIR}/incubator-doris && /bin/bash thirdparty/build-thirdparty.sh     && rm -rf ${DEFAULT_DIR}/incubator-doris/thirdparty/src     && rm -rf ${DEFAULT_DIR}/doris-thirdparty.tar.gz     && rm -rf ${DEFAULT_DIR}/doris-thirdparty     && mkdir -p ${DEFAULT_DIR}/thirdparty     && mv ${DEFAULT_DIR}/incubator-doris/thirdparty/installed ${DEFAULT_DIR}/thirdparty/     && rm -rf ${DEFAULT_DIR}/incubator-doris' returned a non-zero code: 1**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] imay commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
imay commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-631879704


   @morningman 
   I don't understand you very well. I think we can make this feature in our next release, so we can merge it right now. what's your opinion about this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman edited a comment on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
morningman edited a comment on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-641071130


   I thought we had discussed it. .
   If this PR is merged, the current docker image needs to be upgraded, otherwise the new code cannot be compiled. If you think there is no problem, I have no opinion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] imay commented on a change in pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427170693



##########
File path: be/CMakeLists.txt
##########
@@ -264,7 +264,7 @@ check_function_exists(sched_getcpu HAVE_SCHED_GETCPU)
 #  -fno-omit-frame-pointers: Keep frame pointer for functions in register
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall -Wno-sign-compare -Wno-unknown-pragmas -pthread")
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-strict-aliasing -fno-omit-frame-pointer")
-set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++11 -D__STDC_FORMAT_MACROS")
+set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++17 -D__STDC_FORMAT_MACROS")

Review comment:
       ```suggestion
   set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=c++17 -D__STDC_FORMAT_MACROS")
   ```
   why use gnu++17 rather than c++17

##########
File path: env.sh
##########
@@ -55,12 +55,19 @@ if [[ -z ${DORIS_GCC_HOME} ]]; then
 fi
 
 gcc_ver=`${DORIS_GCC_HOME}/bin/gcc -dumpfullversion -dumpversion`
-required_ver="5.3.1"
+required_ver="7.1.0"
 if [[ ! "$(printf '%s\n' "$required_ver" "$gcc_ver" | sort -V | head -n1)" = "$required_ver" ]]; then 
     echo "Error: GCC version (${gcc_ver}) must be greater than or equal to ${required_ver}"
     exit 1
 fi
 
+flex_ver=`flex --version | awk '{print $2}'`

Review comment:
       why do this check? and update flex version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] kangkaisen commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-641067971


   > @morningman
   > I don't understand you very well. I think we can make this feature in our next release, so we can merge it right now. what's your opinion about this?
   
   @morningman Hi, Could we merge this PR now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427414647



##########
File path: env.sh
##########
@@ -55,12 +55,19 @@ if [[ -z ${DORIS_GCC_HOME} ]]; then
 fi
 
 gcc_ver=`${DORIS_GCC_HOME}/bin/gcc -dumpfullversion -dumpversion`
-required_ver="5.3.1"
+required_ver="7.1.0"
 if [[ ! "$(printf '%s\n' "$required_ver" "$gcc_ver" | sort -V | head -n1)" = "$required_ver" ]]; then 
     echo "Error: GCC version (${gcc_ver}) must be greater than or equal to ${required_ver}"
     exit 1
 fi
 
+flex_ver=`flex --version | awk '{print $2}'`

Review comment:
       Yes, of course.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] gengjun-git commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
gengjun-git commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-670811158


   @HappenLee hello, nice to see your contribute, but when I built docker image using your Dockerfile, error occurs as follows, Have you encountered this problem before? Thank you.
   Finished patching s2geometry-0.9.0
   cmake version 3.12.3
   
   CMake suite maintained and supported by Kitware (kitware.com/cmake).
   cmake is found
   byacc - 1.9 20130304
   byacc is found
   flex 2.6.0
   flex is found
   automake (GNU automake) 1.15.1
   Copyright (C) 2017 Free Software Foundation, Inc.
   License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html>
   This is free software: you are free to change and redistribute it.
   There is NO WARRANTY, to the extent permitted by law.
   
   Written by Tom Tromey <tr...@redhat.com>
          and Alexandre Duret-Lutz <ad...@gnu.org>.
   automake is found
   libtoolize (GNU libtool) 2.4.2
   Written by Gary V. Vaughan <ga...@gnu.org>, 2003
   
   Copyright (C) 2011 Free Software Foundation, Inc.
   This is free software; see the source for copying conditions.  There is NO
   warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
   libtool is found
   ===== begin build libevent-master
   autoreconf: Entering directory `.'
   autoreconf: configure.ac: not using Gettext
   autoreconf: running: aclocal --force -I m4
   autoreconf: configure.ac: tracing
   autoreconf: configure.ac: not using Libtool
   autoreconf: running: /usr/bin/autoconf --force
   **configure.ac:129: error: possibly undefined macro: AC_PROG_LIBTOOL
         If this token and others are legitimate, please use m4_pattern_allow.
         See the Autoconf documentation.
   autoreconf: /usr/bin/autoconf failed with exit status: 1
   The command '/bin/sh -c cd ${DEFAULT_DIR}/incubator-doris && /bin/bash thirdparty/build-thirdparty.sh     && rm -rf ${DEFAULT_DIR}/incubator-doris/thirdparty/src     && rm -rf ${DEFAULT_DIR}/doris-thirdparty.tar.gz     && rm -rf ${DEFAULT_DIR}/doris-thirdparty     && mkdir -p ${DEFAULT_DIR}/thirdparty     && mv ${DEFAULT_DIR}/incubator-doris/thirdparty/installed ${DEFAULT_DIR}/thirdparty/     && rm -rf ${DEFAULT_DIR}/incubator-doris' returned a non-zero code: 1**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman closed pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
morningman closed pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427247372



##########
File path: env.sh
##########
@@ -55,12 +55,19 @@ if [[ -z ${DORIS_GCC_HOME} ]]; then
 fi
 
 gcc_ver=`${DORIS_GCC_HOME}/bin/gcc -dumpfullversion -dumpversion`
-required_ver="5.3.1"
+required_ver="7.1.0"
 if [[ ! "$(printf '%s\n' "$required_ver" "$gcc_ver" | sort -V | head -n1)" = "$required_ver" ]]; then 
     echo "Error: GCC version (${gcc_ver}) must be greater than or equal to ${required_ver}"
     exit 1
 fi
 
+flex_ver=`flex --version | awk '{print $2}'`

Review comment:
       Because the C++ code generated by flex uses the keyword ```register```.
   
   From C++11 deprecated the ```register``` keyword.  
   
   In C++17 forbidden use ```register``` keyword.  flex fix the problem after 2.6.0 version.
   
   reference: https://github.com/westes/flex/issues/132




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427255522



##########
File path: be/CMakeLists.txt
##########
@@ -264,7 +264,7 @@ check_function_exists(sched_getcpu HAVE_SCHED_GETCPU)
 #  -fno-omit-frame-pointers: Keep frame pointer for functions in register
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall -Wno-sign-compare -Wno-unknown-pragmas -pthread")
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-strict-aliasing -fno-omit-frame-pointer")
-set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++11 -D__STDC_FORMAT_MACROS")
+set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++17 -D__STDC_FORMAT_MACROS")

Review comment:
       C++ 17 is a subset of GNU++ 17. GNU extends some features not supported by standard C++, such as ```__ Int128``` which we used in Doris code. so I use GNU here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-631454781


   @kangkaisen ok,i will update the document of doris。but about the part of docker image version. maybe we should chose a version and commid id  to start use C++17.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] kangkaisen commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-631190697


   @HappenLee Hi,You should also update this  http://doris.apache.org/master/zh-CN/installing/compilation.html#%E7%9B%B4%E6%8E%A5%E7%BC%96%E8%AF%91%EF%BC%88centos-ubuntu%EF%BC%89 doc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] imay commented on a change in pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427371806



##########
File path: env.sh
##########
@@ -55,12 +55,19 @@ if [[ -z ${DORIS_GCC_HOME} ]]; then
 fi
 
 gcc_ver=`${DORIS_GCC_HOME}/bin/gcc -dumpfullversion -dumpversion`
-required_ver="5.3.1"
+required_ver="7.1.0"
 if [[ ! "$(printf '%s\n' "$required_ver" "$gcc_ver" | sort -V | head -n1)" = "$required_ver" ]]; then 
     echo "Error: GCC version (${gcc_ver}) must be greater than or equal to ${required_ver}"
     exit 1
 fi
 
+flex_ver=`flex --version | awk '{print $2}'`

Review comment:
       Good explain!
   Can you add this explain to the source code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] imay commented on a change in pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427371183



##########
File path: be/CMakeLists.txt
##########
@@ -264,7 +264,7 @@ check_function_exists(sched_getcpu HAVE_SCHED_GETCPU)
 #  -fno-omit-frame-pointers: Keep frame pointer for functions in register
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall -Wno-sign-compare -Wno-unknown-pragmas -pthread")
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-strict-aliasing -fno-omit-frame-pointer")
-set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++11 -D__STDC_FORMAT_MACROS")
+set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++17 -D__STDC_FORMAT_MACROS")

Review comment:
       OK




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-800732730


   Closed, move to #5394 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#discussion_r427255522



##########
File path: be/CMakeLists.txt
##########
@@ -264,7 +264,7 @@ check_function_exists(sched_getcpu HAVE_SCHED_GETCPU)
 #  -fno-omit-frame-pointers: Keep frame pointer for functions in register
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall -Wno-sign-compare -Wno-unknown-pragmas -pthread")
 set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-strict-aliasing -fno-omit-frame-pointer")
-set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++11 -D__STDC_FORMAT_MACROS")
+set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -std=gnu++17 -D__STDC_FORMAT_MACROS")

Review comment:
       C++ 17 is a subset of GNU++ 17. Gun extends some features not supported by standard C++, such as ```__ Int128``` which we used in Doris code. so I use GNU here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-631484829


   I suggest to merge this PR before we planing to release next version.
   So we can have a clear cut of the dev environment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] HappenLee commented on pull request #3626: Update Compiling environment of BE to Support C++14/17

Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #3626:
URL: https://github.com/apache/incubator-doris/pull/3626#issuecomment-671003858


   > @HappenLee hello, nice to see your contribute, but when I built docker image using your Dockerfile, error occurs as follows, Have you encountered this problem before? Thank you.
   > 
   > ============log===================
   > 
   > Finished patching s2geometry-0.9.0
   > cmake version 3.12.3
   > 
   > CMake suite maintained and supported by Kitware (kitware.com/cmake).
   > cmake is found
   > byacc - 1.9 20130304
   > byacc is found
   > flex 2.6.0
   > flex is found
   > automake (GNU automake) 1.15.1
   > Copyright (C) 2017 Free Software Foundation, Inc.
   > License GPLv2+: GNU GPL version 2 or later http://gnu.org/licenses/gpl-2.0.html
   > This is free software: you are free to change and redistribute it.
   > There is NO WARRANTY, to the extent permitted by law.
   > 
   > Written by Tom Tromey [tromey@redhat.com](mailto:tromey@redhat.com)
   > and Alexandre Duret-Lutz [adl@gnu.org](mailto:adl@gnu.org).
   > automake is found
   > libtoolize (GNU libtool) 2.4.2
   > Written by Gary V. Vaughan [gary@gnu.org](mailto:gary@gnu.org), 2003
   > 
   > Copyright (C) 2011 Free Software Foundation, Inc.
   > This is free software; see the source for copying conditions. There is NO
   > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
   > libtool is found
   > ===== begin build libevent-master
   > autoreconf: Entering directory `.'
   > autoreconf: configure.ac: not using Gettext
   > autoreconf: running: aclocal --force -I m4
   > autoreconf: configure.ac: tracing
   > autoreconf: configure.ac: not using Libtool
   > autoreconf: running: /usr/bin/autoconf --force
   > **configure.ac:129: error: possibly undefined macro: AC_PROG_LIBTOOL If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1 The command '/bin/sh -c cd ${DEFAULT_DIR}/incubator-doris && /bin/bash thirdparty/build-thirdparty.sh && rm -rf ${DEFAULT_DIR}/incubator-doris/thirdparty/src && rm -rf ${DEFAULT_DIR}/doris-thirdparty.tar.gz && rm -rf ${DEFAULT_DIR}/doris-thirdparty && mkdir -p ${DEFAULT_DIR}/thirdparty && mv ${DEFAULT_DIR}/incubator-doris/thirdparty/installed ${DEFAULT_DIR}/thirdparty/ && rm -rf ${DEFAULT_DIR}/incubator-doris' returned a non-zero code: 1**
   
   I do not meet this problem, i wiil check the docker compile again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org